Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1817
I've retriggered CI a few times. Current error is
```
Failed tests:
NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760
expected: bu
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1817
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1817
remove usage of non-standard string method
### What is this PR for?
Recreating #1701 that was lost in refactoring.
This PR removes a non-standard string prototype method `contains
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1817
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1817
remove usage of non-standard string method
### What is this PR for?
Recreating #1701 that was lost in refactoring.
This PR removes a non-standard string prototype method `contains
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1815
I generally wish that api would be designed more like d3 or jquery, e.g.
something along the lines of `visualization(el).render()`; without the need of
calling it with `new`; it is more aligned
GitHub user felizbear opened a pull request:
https://github.com/apache/zeppelin/pull/1818
[ZEPPELIN-1873] Use exclusively eslint for javascript code linting
### What is this PR for?
[jscs](http://jscs.info) has merged with [eslint](http://eslint.org),
therefore both should be
GitHub user felizbear opened a pull request:
https://github.com/apache/zeppelin/pull/1817
remove usage of non-standard string method
### What is this PR for?
This PR removes a non-standard string prototype method `contains` that can
cause potential bugs in the future
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1791
@1ambda thank you for the research. A couple of questions:
1. Why do you think it requires changing dir structure?
2. What do you mean by: "we need index.html first."?
-
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1791
We totally can but it requires some effort, i.e. migrating code to es6
modules
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1791
GOOD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1714
All checks have passed. Let's merge it please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in
paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most
functions in
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in
paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most
functions in
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in
paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most
functions in
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in
paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most
functions in
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1714
this backend test currently fails
```
- should provide onclick method *** FAILED ***
The code passed to eventually never returned normally. Attempted 1 times
over
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in
paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most
functions in
GitHub user felizbear opened a pull request:
https://github.com/apache/zeppelin/pull/1714
Fe explicit arguments
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most
functions in paragraph controller to accept explicit parameters instead
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@Peilin-Yang a quick question: for some reason, when setting `value` to
date type i get this
https://cloud.githubusercontent.com/assets/5688346/20740396/03b9b9f2-b706-11e6-933c
GitHub user felizbear opened a pull request:
https://github.com/apache/zeppelin/pull/1701
remove usage of non-standard string method
### What is this PR for?
This PR removes non-standard string prototype method that can cause
potential bugs in the future maintenance
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1673
@bzz it's definitely the simplest solution I'm aware of. it increases `npm
test` time since it tries to install phantom every time you run it, but that's
fine I guess. LGT
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1639
[ZEPPELIN-1667] add support for es6
### What is this PR for?
This PR adds support for the current ECMAScript standard
[es6](http://www.ecma-international.org/ecma-262/6.0/) via
[babel
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1659
@1ambda great analysis!
> Basically, we use node as a tool. not the runtime
This makes a lot of sense
---
If your project is set up for it, you can reply to this email
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1659
I don't really have a strong opinion about node / npm versions. @bzz what's
the reasoning behind consolidating versions with other apache projects?
---
If your project is set up f
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda wow GREAT WORK! Thanks a lot for your effort!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1639
[ZEPPELIN-1667] add support for es6
### What is this PR for?
This PR adds support for the current ECMAScript standard
[es6](http://www.ecma-international.org/ecma-262/6.0/) via
[babel
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1639
[ZEPPELIN-1667] add support for es6
### What is this PR for?
This PR adds support for the current ECMAScript standard
[es6](http://www.ecma-international.org/ecma-262/6.0/) via
[babel
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1639
[ZEPPELIN-1667] add support for es6
### What is this PR for?
This PR adds support for the current ECMAScript standard
[es6](http://www.ecma-international.org/ecma-262/6.0/) via
[babel
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@bzz I don't think `maven clean` removes `.tmp` even in master. `grunt
clean` however does the job well
---
If your project is set up for it, you can reply to this email and have your
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
But also it's weird. The only difference in build is the babel task, which
just can't take over a minute. Or can it? :/
---
If your project is set up for it, you can reply to this
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda well, i was overly optimistic saying that the build time change is
virtually non-existent :(
---
If your project is set up for it, you can reply to this email and have your
reply
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1639
[ZEPPELIN-1667] add support for es6
### What is this PR for?
This PR adds support for the current ECMAScript standard
[es6](http://www.ecma-international.org/ecma-262/6.0/) via
[babel
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Thank you @bzz for your detailed comment and suggestions.
> it's impact on build time
The impact on build time is virtually non-existent. There is some impact on
rel
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@tae-jun I'm gonna trigger the build one more time. If it fails, could you
help me out with `.travis.yml`? Let's try to merge it ASAP guys.
---
If your project is set up for it, you
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1639
[ZEPPELIN-1667] add support for es6
### What is this PR for?
This PR adds support for the current ECMAScript standard
[es6](http://www.ecma-international.org/ecma-262/6.0/) via
[babel
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1639
[ZEPPELIN-1667] add support for es6
### What is this PR for?
This PR adds support for the current ECMAScript standard
[es6](http://www.ecma-international.org/ecma-262/6.0/) via
[babel
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda `grunt test` works well for me. Does it fail only in this branch?
e.g. `master` works fine for you?
Also, CI failed for this PR. Any advice?
---
If your project is set up for
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda, @tae-jun
Thanks for reviewing guys.
@tae-jun
Auto-opening browser is actually my least-favorite feature; I removed it
for two reasons
1. It always opens the
GitHub user felizbear opened a pull request:
https://github.com/apache/zeppelin/pull/1639
[ZEPPELIN-1667] add support for es6
### What is this PR for?
This PR adds support for the current ECMAScript standard
[es6](http://www.ecma-international.org/ecma-262/6.0/) via
[babel
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1100
Not sure how to test in the browser because I have to log in, but I have no
clue how to register. And don't really understand why I have to do it to access
settings.
Li
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/978
@ravicodder except for [this
remark](https://github.com/apache/zeppelin/pull/978#discussion_r66751128), LGTM
---
If your project is set up for it, you can reply to this email and have your
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/978
Also, I think you will have to clean up scope after you clear the search
field value. To see what I mean do the following:
1. Search for something, e.g. `bankText`
2. Navigate away from
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/978
Thanks for contribution by the way :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/978
Also, I would recommend modify `ng-disabled` of search form in navbar like
this:
```
ng-disabled="!navbar.connected || !searchTerm"
```
so it doesn't fire when th
Github user felizbear commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/929#issuecomment-222578766
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
59 matches
Mail list logo
