[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

2017-08-16 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/2518 @Leemoonsoo Merging the upstream and restarting the travis build did the trick.Here is the travis link for this PR-https://travis-ci.org/SachinJanani/zeppelin/builds/265444667.Can you

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

2017-08-14 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/2518 Yes @Leemoonsoo I have tried restarting failed job but it didn't succeed :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

2017-08-09 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/2518 This build is failing due to some environment issue in jenkins can someone please help me out. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

2017-08-09 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/2518 @Leemoonsoo Thanks for the review.Have started the travis build. @felixcheung With this change it will not clear the output if the execution fails and keep the previous output.But if there

[GitHub] zeppelin pull request #2518: Fixing zeppelin-2281 by clearing output when da...

2017-08-06 Thread SachinJanani
GitHub user SachinJanani opened a pull request: https://github.com/apache/zeppelin/pull/2518 Fixing zeppelin-2281 by clearing output when data is available ### What is this PR for? Fixing ZEPPELIN-2281 by clearing previous when new data is available ### What type

[GitHub] zeppelin pull request #1234: [ZEPPELIN-1234] Fix issue related to indefinite...

2016-08-03 Thread SachinJanani
Github user SachinJanani closed the pull request at: https://github.com/apache/zeppelin/pull/1234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix issue related to indefinite waitin...

2016-08-03 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1234 @jongyoul Sure I will close it now.Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix issue related to indefinite waitin...

2016-08-03 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1234 @jongyoul I revised the PR title and its description --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix for bug ZEPPELIN-1234

2016-08-02 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1234 Travis checks are failing but are not related to this changes.@jongyoul Can you please have a look. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix for bug ZEPPELIN-1234

2016-07-27 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1234 Failure of travis check is not related to this change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin pull request #1234: [ZEPPELIN-1234] Fix for bug ZEPPELIN-1234

2016-07-26 Thread SachinJanani
GitHub user SachinJanani opened a pull request: https://github.com/apache/zeppelin/pull/1234 [ZEPPELIN-1234] Fix for bug ZEPPELIN-1234 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contrib

[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-22 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1197 Thanks @minahlee --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-21 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1197 @jongyoul This changes are only for branch-0.6 as master does not have this files (even this code) anymore due to helium changes.Also i think issue might not occur for zeppelin-0.7.So this

[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-20 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1197 Can someone please merge this PR as I don't have permission --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-19 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1197 Thanks @jongyoul. Sure will make the change also will add a comment in the code about about the 30 seconds timeout --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-18 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1172 @corneadoug Yes you are right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-18 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1197 @jongyoul One more thing I found that as per ZEPPELIN_INTERPRETER_CONNECT_TIMEOUT property default timeout that we consider is 30 seconds.So I think setting it to 30 seconds will make more

[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-18 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1197 @jongyoul Yes you are right if RemoteInterpreterServer fails to launch within 10 seconds then this test will fail,but we need to have some threshold for that because if say there is some

[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-18 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1197 @jongyoul Thanks for reviewing.As suggested I have added a test case for this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1172: [Zeppelin-1161] Revert precise execution time

2016-07-18 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1172 @corneadoug Will this changes also be available in 0.6.1 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-17 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1197 Can someone please review this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-17 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/1197 One of the travis check is failing but its not related to my changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-16 Thread SachinJanani
GitHub user SachinJanani opened a pull request: https://github.com/apache/zeppelin/pull/1197 [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196 ### What is this PR for? Fixed issue related to connecting to remote running interpreter process with multiple interpreters in interpreter

[GitHub] zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to connect to alre...

2016-06-11 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/955 Thanks @Leemoonsoo @jongyoul @AhyoungRyu @corneadoug For reviewing.Can someone please merge this pull request? --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to connect to alre...

2016-06-10 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/955 Can we merge this if there are no more comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to connect to alre...

2016-06-09 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/955 @jongyoul @corneadoug Done with the docs can you please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to connect to alre...

2016-06-09 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/zeppelin/pull/955 @jongyoul Should I add section in "docs/manual/interpreters.md" something like "Connecting to the Existing Remote Interpreter"? --- If your project is set up for it, y

[GitHub] incubator-zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to conne...

2016-06-08 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/incubator-zeppelin/pull/955 @jongyoul Yes you are right.But this changes will allow user to connect to existing remote process instead of zeppelin running the interpreter.I think we should create a separate

[GitHub] incubator-zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to conne...

2016-06-08 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/incubator-zeppelin/pull/955 @jongyoul There can be scenarios where user is starting RemoteInterpreter embedded in his service by calling `RemoteInterpreterServer server = new RemoteInterpreterServer(port

[GitHub] incubator-zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to conne...

2016-06-08 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/incubator-zeppelin/pull/955 @Leemoonsoo @jongyoul One of the TravisCI task is failing but I think its not related to my changes, is there any way I can rerun the travisCI without pushing changes? --- If

[GitHub] incubator-zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to conne...

2016-06-07 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/incubator-zeppelin/pull/955 @Leemoonsoo @jongyoul This is what will look now: ![7_6](https://cloud.githubusercontent.com/assets/5284975/15858782/ee478c76-2cdf-11e6-8c08-c59298df8563.png) ![7_8](https

[GitHub] incubator-zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to conne...

2016-06-06 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/incubator-zeppelin/pull/955 @Leemoonsoo Even I think adding a checkbox will make more sense.As TravisCI was failing I have merged master in my fork which caused those commits to appear as a part of this

[GitHub] incubator-zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to conne...

2016-06-06 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/incubator-zeppelin/pull/955 @Leemoonsoo As suggested i have added UI component for the host and port in the interpreter settings.Please see the attached image of how it will look. ![3](https

[GitHub] incubator-zeppelin issue #955: [ZEPPELIN-940] Allow zeppelin server to conne...

2016-06-05 Thread SachinJanani
Github user SachinJanani commented on the issue: https://github.com/apache/incubator-zeppelin/pull/955 @Leemoonsoo You mean that there should be one more option under option dropdown something like "isexecuting" and when this option is selected we have to show 2 propertie

[GitHub] incubator-zeppelin pull request #955: [ZEPPELIN-940] Allow zeppelin server t...

2016-06-03 Thread SachinJanani
GitHub user SachinJanani opened a pull request: https://github.com/apache/incubator-zeppelin/pull/955 [ZEPPELIN-940] Allow zeppelin server to connect to already executing Remote Interpreter ### What is this PR for? Currenlty zeppelin server starts interpreter on localhost and