Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@felizbear
The code of this PR uses `momentjs` to parse the string to date.
Specifically, http://momentjs.com/docs/#/parsing/string/
Integers are not of ISO8601 format so
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@bzz able to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@bzz done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@corneadoug thanks, the error is really strange.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@corneadoug I've tested using `./grunt test` and it passed the test. But CI
check still failed.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@corneadoug do you have chance to look at what is wrong with the commit? thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Peilin-Yang closed the pull request at:
https://github.com/apache/zeppelin/pull/1500
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user Peilin-Yang reopened a pull request:
https://github.com/apache/zeppelin/pull/1500
[ZEPPELIN-1371]add text/numeric conversion support to table display
### What is this PR for?
We people in Twitter have great demand of adding a flexible drop down menu
for the columns
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@corneadoug can you see whether it can pass the test now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@corneadoug updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@corneadoug It was very weird.
Can you tell how to test?
I have changed the numeric value 1,787 to 1787 but it seems that the
failure is because of (maybe) some encoding/decoding at
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@corneadoug I have changed the test case. Could you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@corneadoug done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@corneadoug It was really messy to rebase so I created this new PR. The
previous one was closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user Peilin-Yang opened a pull request:
https://github.com/apache/zeppelin/pull/1500
[ZEPPELIN-1371]add text/numeric conversion support to table display
### What is this PR for?
We people in Twitter have great demand of adding a flexible drop down menu
for the columns in
Github user Peilin-Yang closed the pull request at:
https://github.com/apache/zeppelin/pull/1363
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug I have trouble with the rebase:( ... can you help a little bit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug merged your PR.
Do you think now it is the good time to merge this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug I have fixed the bug you mentioned. Testing was done and it
seems ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug I just found that Handsontable has its intrinsic data type
detection/conversion which we can rely on for the type conversion and is thus
safer. More details at http
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug can we get this reviewed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
I made several changes for this commit:
1. put the style from notebook.css to paragraph.css
2. do not make any assumption/auto-detection of the original type of the
data
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on
project zeppelin-interpreter: Compilation failure
[ERROR]
/Users/yizhang
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
@corneadoug fetched branch-0.6 but compile failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
@corneadoug sure, I can do that once having time:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
I have changed the logic of code a bit.
Since it is just impossible to maintain a list of date formats for parsing
purpose, now I just take whatever in the cell (if the value was proven
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
@corneadoug thanks for all your feedbacks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
BTW, for the dates detection I made a pre-defined list of supported formats
and used the strict mode for moment.js parsing. The format "x" or "X" which
corresponds to th
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
@corneadoug The ideal case is to fetch the type from back end. But that is
pretty hard. There are several types of interpreters (Sql, Spark, AngularJS,
Shell etc..) in the back end and create
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
@echarles Yes the table can only hold limited number of rows (1000) to not
to overload the client. I think the limit is set by the interpreter not the
front end client. That said, there is no
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@bzz I agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
@bzz yes, this will basically touch every cell in the table. I do not think
just visiting a few rows would work as the sorting is done by HudsonTable and
it loads all data for sorting purpose
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1371
@arunsoman Yes. in this PR the code can automatically detect the type of
the cells, but restricted to strings and numbers. Dates can be added either and
this is a good idea.
In my other
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
Added another PR #1371 that may have impact on this one.
i.e. if you guys think that one is reasonable then this one should be
adjusted so that when user changes the datatype of the column
GitHub user Peilin-Yang opened a pull request:
https://github.com/apache/zeppelin/pull/1371
[ZEPPELIN-1372]
### What is this PR for?
Automatically detect the data type for the contents in the table.
This enables the sorting on numerical columns.
Please see #1372 for
Github user Peilin-Yang closed the pull request at:
https://github.com/apache/zeppelin/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user Peilin-Yang reopened a pull request:
https://github.com/apache/zeppelin/pull/1351
[ZEPPELIN/1356] The graph legend truncates at the nearest period (.) in its
grouping
### What is this PR for?
Fix the issue: in line graph if user uses the numbers that contains
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1351
@corneadoug should I make the CI build successful? I do not know the
failure is because of my commit.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1351
@prabhjyotsingh I agree with @corneadoug
truncation on numeric values in the legend to me is another
improvement/feature.
What this PR does is to fix the bug of existing code
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1351
@corneadoug sure, will do and push
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1351
@bzz is that possible to apply this to 0.6.0-SNAPSHOT. We are still using
that version in Twitter:)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
Well, consider it alone, yes it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@bzz Actually I am currently look into that and I think it is possible
because numbers are automatically detected and that is why the commas are
inserted.
But I think even we could have
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug thanks for your advice!
I updated the contents of PR so that it includes the use cases of this
change.
Please let me know whether they make any sense.
---
If your project
GitHub user Peilin-Yang reopened a pull request:
https://github.com/apache/zeppelin/pull/1363
[ZEPPELIN-1371]add text/numeric conversion support to table display
### What is this PR for?
We people in Twitter have great demand of adding a flexible drop down menu
for the columns
Github user Peilin-Yang closed the pull request at:
https://github.com/apache/zeppelin/pull/1363
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Peilin Yang created ZEPPELIN-1372:
-
Summary: sorting order in the table is always lexicographically
even it shows as numbers
Key: ZEPPELIN-1372
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1372
GitHub user Peilin-Yang opened a pull request:
https://github.com/apache/zeppelin/pull/1363
[ZEPPELIN-1371]add text/numeric conversion support to table display
### What is this PR for?
We people in Twitter have great demand of adding a flexible drop down menu
for the columns in
Peilin Yang created ZEPPELIN-1371:
-
Summary: Add flexible text/numeric conversion dropdown menu on
table display
Key: ZEPPELIN-1371
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1371
Project
GitHub user Peilin-Yang reopened a pull request:
https://github.com/apache/zeppelin/pull/1351
[ZEPPELIN/1356] The graph legend truncates at the nearest period (.) in its
grouping
### What is this PR for?
Fix the issue: in line graph if user uses the numbers that contains
Github user Peilin-Yang closed the pull request at:
https://github.com/apache/zeppelin/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user Peilin-Yang reopened a pull request:
https://github.com/apache/zeppelin/pull/1351
[ZEPPELIN/1356] The graph legend truncates at the nearest period (.) in its
grouping
### What is this PR for?
Fix the issue: in line graph if user uses the numbers that contains
Github user Peilin-Yang closed the pull request at:
https://github.com/apache/zeppelin/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user Peilin-Yang reopened a pull request:
https://github.com/apache/zeppelin/pull/1351
[ZEPPELIN/1356] The graph legend truncates at the nearest period (.) in its
grouping
### What is this PR for?
Fix the issue: in line graph if user uses the numbers that contains
Github user Peilin-Yang closed the pull request at:
https://github.com/apache/zeppelin/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user Peilin-Yang reopened a pull request:
https://github.com/apache/zeppelin/pull/1351
[ZEPPELIN/1356] The graph legend truncates at the nearest period (.) in its
grouping
### What is this PR for?
Fix the issue: in line graph if user uses the numbers that contains
Github user Peilin-Yang closed the pull request at:
https://github.com/apache/zeppelin/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user Peilin-Yang opened a pull request:
https://github.com/apache/zeppelin/pull/1351
[ZEPPELIN/1356] The graph legend truncates at the nearest period (.) in its
grouping
### What is this PR for?
Fix the issue: in line graph if user uses the numbers that contains
period
Peilin Yang created ZEPPELIN-1356:
-
Summary: The graph legend truncates at the nearest period (.) in
its grouping
Key: ZEPPELIN-1356
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1356
Project
59 matches
Mail list logo
