[GitHub] zeppelin issue #3263: ZEPPELIN-3907. Add code statement into Spark JobGroup ...

2018-12-14 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/3263 While this is a really nice feature to have, it does introduce some risk of information leakage in an organization. Take for example `select * from tableofsecrets where secretcolumn

[GitHub] zeppelin issue #2544: [ZEPPELIN-2724] Another Attempt to solve the dead lock...

2017-09-11 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/2544 Any updates on this? ---

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

2017-05-11 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/2334 I looked at the tests, and they fail at the same place even after re-running them, but it seems unrelated to my changes. Could someone else also take a look and see if I'm missing some

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

2017-05-10 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/2334 @zjffdu I agree. A also noticed there are plenty of sketchy `synchrnoized`-blocks that doesn't really work as intended. But that's a refactor for another PR --- If your project is

[GitHub] zeppelin pull request #2334: [HOTFIX] Set interpreter context in zeppelin co...

2017-05-10 Thread FireArrow
GitHub user FireArrow opened a pull request: https://github.com/apache/zeppelin/pull/2334 [HOTFIX] Set interpreter context in zeppelin context from SparkSqlInterpreter ### What is this PR for? When running %sql paragraphs the query is dispatched to the cluster, but when it&#

[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...

2017-05-09 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/2322 I'm all for refactoring the use of synchronized into using more proper data types instead. It's to easy to get stuck in a [live|dead]lock when doing the synchronized yourself -

[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...

2017-03-02 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1985 Terribly sorry for late answer! Not sure why I didn't get any notifications about your answers :confused: @zjffdu I haven't looked into who actually sends the signal, but if it

[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...

2017-02-27 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1985 I have basically only set up zeppelin in isolated mode with impersonation, so I'm not sure what is the "expected" behavior is outside of that. Someone else will have to pitch in

[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...

2017-02-24 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1985 @astroshim That's not what I'm talking about. Assume the following: Zeppelin run as user "zeppelin" In `zeppelin-env.sh`: `export ZEPPELIN_IMPERSONAT

[GitHub] zeppelin issue #2034: [ZEPPELIN-2133] All interpreters sometimes throw rando...

2017-02-21 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/2034 There should probably be a jira to decide the effect of restarting in different locations. For example: As an admin I expect the restart button in Interpreter to force a restart of all

[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...

2017-02-20 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1985 Sorry for the late comment. This solution wouldn't work with impersonation, as the zeppelin user wouldn't have permission to interrupt another users process (unless zeppelin r

[GitHub] zeppelin issue #2034: [ZEPPELIN-2133] All interpreters sometimes throw rando...

2017-02-20 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/2034 I think restart from settings in the table above should have the same behavior as edit+save. The settings page is generally considered an administrative function, and as long as there is a

[GitHub] zeppelin issue #1783: Zeppelin 727

2016-12-20 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1783 I agree with @AhyoungRyu. What she describes is the common way to link to paragraphs, so it seems reasonable to assume that is what users are used to. --- If your project is set up for it, you

[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-16 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1776 LGTM. Test failure seems unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1762: [ZEPPELIN-1810] Removed incorrect usage of getString

2016-12-15 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1762 And after rebasing master the failure is gone. Some kind of race in the test? Anyway, it doesn't seem to be related to the changes in this pull request --- If your project is set up f

[GitHub] zeppelin issue #1762: [ZEPPELIN-1810] Removed incorrect usage of getString

2016-12-15 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1762 Failure seems unrelated... It fails with a null pointer here: https://github.com/FireArrow/zeppelin/blob/ZEPPELIN-1810%5D/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook

[GitHub] zeppelin pull request #1762: [ZEPPELIN-1810] Removed incorrect usage of getS...

2016-12-14 Thread FireArrow
GitHub user FireArrow opened a pull request: https://github.com/apache/zeppelin/pull/1762 [ZEPPELIN-1810] Removed incorrect usage of getString ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check ou