Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/2250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/2250
[ZEPPELIN-2085] Interpret scala code in paste mode
### What is this PR for?
Don't split scala code to lines.
Interpreter code becomes more and more complicated because some
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/2250
Please explain what issues I need to fix)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/2372
Any other questions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/2389
[MINOR] Remove duplicates from ZeppelinConfiguration
### What is this PR for?
Remove duplicated code from `ZeppelinConfiguration` and make proper use of
commons-configuraion
And I
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/2372
I understand that `highlight.js` is a library and can be used anywhere. But
we can't apply it to shell output because output is already highlighted. For
example, `ls` inserts color codes t
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/2372
I am not sure If themes should be shell interpreter feature. Maybe we can
provide themes for every interpreter's text output?
highlight.js should be used for input, not output. O
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/2372
[ZEPPELIN-2581] Shell ansi codes
### What is this PR for?
Support ANSI escape codes for colors in shell interpreter output
### What type of PR is it?
[Improvement
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/2250
Finally done PR and travis is green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/2250
[WIP][ZEPPELIN-2085] Interpret scala code in paste mode
### What is this PR for?
Don't split scala code to lines.
Interpreter code becomes more and more complicated because some
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/2039
`interrupt` just sets `Thread.isInterrupted` flag and does not immediately
stop the thread. Then thread can check this flag and decide if it needs to
stop. So in fact, termination logic remains
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/2039
Ping-ping)
Do you have other questions? Do you think it's better to proper synchronize
`terminate` flag instead?
I reviewed code to understand how zeppelin core works and
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/2039
@felixcheung `terminate` flag is shared across several threads and is
accessed without any synchronization.
And we don't need to implement custom interruption flag because java
already h
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/2039
[MINOR] Use standard java API to interrupt thread
### What is this PR for?
Use java `Thread.interrupt` method to stop job progress polling thread.
Standard API is:
* proper
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1946
@jongyoul sorry for late response!
I checked failure. It's related to PR but I don't know how to fix it
Build profile uses
```
$ export SCALA_VER="2.1
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1911
I tried to wrap with `ClassloaderInterpreter` and it works
But I don't like this solution. We force every user of `IgniteInterpreter`
to wrap it with `ClassloaderInterpreter`. It&#
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1946
[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
### What is this PR for?
Applies new registration mechanism for R interpreter
### What type of PR is it?
[Refactoring
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1946
Rebased on master and ran build.
I tried several times:
- https://travis-ci.org/apache/zeppelin/builds/197341657
- https://travis-ci.org/apache/zeppelin/builds/197539698
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1946
[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
### What is this PR for?
Applies new registration mechanism for R interpreter
### What type of PR is it?
[Refactoring
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1946
[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
### What is this PR for?
Applies new registration mechanism for R interpreter
### What type of PR is it?
[Refactoring
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1944
Actually, compilation succeed without this dependency. Try remove it from
pom and run
```
mvn package -pl zeppelin-server -am -DskipTests
```
Tests don't use it, there
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1944
@Leemoonsoo Could you please provide your dependency:tree output?
Surprisingly it's a maven feature. `Test` scope in local pom overrides
`compile` scope for transitive depende
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1937
Hello!
Are there any other ideas how we can add R interpreter to spark group
without touching spark's interpreter-settings.json?
---
If your project is set up for it, you can rep
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1949
```
Tests in error:
InterpreterRestApiTest.testRestartInterpreterPerNote:303 NullPointer
```
It's a known bug https://issues.apache.org/jira/browse/ZEPPELIN-1856
-
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1949
[MINOR] Refactor to modern apis
### What is this PR for?
Use modern api to write less and try-with-resources to close file in case
of errors
### What type of PR is it
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1949
@Leemoonsoo Of course! Unfortunately, build log is truncated and I can't
find out why it failed
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1949
[MINOR] Refactor to modern apis
### What is this PR for?
Use modern api to write less and try-with-resources to close file in case
of errors
### What type of PR is it
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1949
[MINOR] Refactor to modern apis
### What is this PR for?
Use modern api to write less and try-with-resources to close file in case
of errors
### What type of PR is it
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1944
Hello! I have the same issue
I checked dependency:tree output,
`org.apache.httpcomponents:httpclient:jar:4.3.6` has `test` scope in
`zeppelin-server` module.
---
If your project
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1946
Needs this changes: #1937
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1946
[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
### What is this PR for?
Applies new registration mechanism for R interpreter
### What type of PR is it?
[Refactoring
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1937
@jongyoul currently R interpreter uses static initialization and isn't
loaded at all =)
I will create pull request with interpreter-settings.json for R
interpreter. But it needs th
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1911
Yes, I tried ClassloaderInterpreter but it didn't fix original issue.
https://github.com/apache/zeppelin/blob/master/ignite/src/test/java/org/apache/zeppelin/i
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1937
@jongyoul PR for loading several interpreter-setting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1937
Search for interpreter-settings in several jars in folder
### What is this PR for?
`InterpreterFactory` searches for single `interpreter-settings.json` in
some jar in folder. This PR allows
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1911
@Leemoonsoo @jongyoul thank you! I didn't know about ClassLoaderInterpreter
Unfortunately, our tests don't use InterpreterFactory and will use
unwrapped Interpreter instance. S
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1911
@jongyoul I checked SparkInterpreter, it has the same issue with context
class loader
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1911
[ZEPPELIN-1972] Preserve context classloader
### What is this PR for?
`IMain.interpret` changes current thread's context classloader. It may
cause different issues and definitely i
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1782
Ping?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1819
Travis fails with:
```
testBasicIntp(org.apache.zeppelin.spark.PySparkInterpreterTest) Time
elapsed: 58.947 sec <<< FAILURE!
java.lang.AssertionError: expected
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1819
Original pull request #1561
IgniteSqlInterpreterTest is known flaky test:
[ZEPPELIN-1738](https://issues.apache.org/jira/browse/ZEPPELIN-1738)
---
If your project is set up for it, you
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1561
New pull request #1819
I rebased it on the latest master and fixed failing test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1819
[ZEPPELIN-914] Apply new mechanism to IgniteInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1561
Hello!
I would like to help with
[ZEPPELIN-804](https://issues.apache.org/jira/browse/ZEPPELIN-804) subtasks and
make it possible to complete refactoring
If you don't mind I
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1759
Ping-ping! :-)
What should I do to complete pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1782
@bzz @1ambda I attached CI logs
Failures are:
* `ZeppelinIT.testAngularDisplay:157->AbstractZeppelinIT.waitForText:84 »
StaleElementReference`
* `AngularElemT
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1782
[ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure
### What is this PR for?
Fix possible reason of DepInterpreterTest failure
### What type of PR is it?
[Bug Fix
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1782
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1782
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1782
[ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure
### What is this PR for?
Fix possible reason of DepInterpreterTest failure
### What type of PR is it?
[Bug Fix
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1782
@1ambda yes, of course
* https://travis-ci.org/apache/zeppelin/builds/185383249
* https://travis-ci.org/apache/zeppelin/builds/185389810
* https://travis-ci.org/apache/zeppelin
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1782
[ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure
### What is this PR for?
Fix possible reason of DepInterpreterTest failure
### What type of PR is it?
[Bug Fix
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1782
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1782
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1782
[ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure
### What is this PR for?
Fix possible reason of DepInterpreterTest failure
### What type of PR is it?
[Bug Fix
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1782
[ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure
### What is this PR for?
Fix possible reason of DepInterpreterTest failure
### What type of PR is it?
[Bug Fix
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1782
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1782
[ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure
### What is this PR for?
Fix possible reason of DepInterpreterTest failure
### What type of PR is it?
[Bug Fix
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1769
Ready to review
One test failed, but it seems to be irrelevant
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1769
@Leemoonsoo Thank you for reply!
I forgot about tests, it's my fault.
Tests didn't pass `zeppelin.dep.localrepo` property to interpreter. That's
why DependecyRes
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1769
[ZEPPELIN-1818] Absolute local repo path in dependency downloader
### What is this PR for?
Allow dependency resolver to use absolute path for local repo
### What type of PR is it
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1759
[ZEPPELIN-922] New interpreter registration mechanism for Scalding
### What is this PR for?
Applies the new interpreter registration mechanism to Alluxio interpreter.
### What type of
67 matches
Mail list logo
