[GitHub] [zeppelin] Reamer commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581919786 A `synchronized` at the `saveNoteAuth` method should fix the problem. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581779073 Thanks for your reply. This pull request migrates solve the concurrency problem caused by multiple concurrent calls to `org.apache.zeppelin.notebook.AuthorizationService#saveNoteAu

[GitHub] [zeppelin] zhugezifang commented on a diff in pull request #4612: [ZEPPELIN-5926] Remove map entries if Collection is empty

2023-06-07 Thread via GitHub
zhugezifang commented on code in PR #4612: URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1222353767 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java: ## @@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) { p

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4612: [ZEPPELIN-5926] Remove map entries if Collection is empty

2023-06-07 Thread via GitHub
jongyoul commented on code in PR #4612: URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1221824271 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java: ## @@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) { publ

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4612: [ZEPPELIN-5926] Remove map entries if Collection is empty

2023-06-07 Thread via GitHub
Reamer commented on code in PR #4612: URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1221819108 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java: ## @@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) { public

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4612: [ZEPPELIN-5926] Remove map entries if Collection is empty

2023-06-07 Thread via GitHub
jongyoul commented on code in PR #4612: URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1221525956 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java: ## @@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) { publ

[jira] [Created] (ZEPPELIN-5926) zeppelin_user_sockets and zeppelin_note_sockets are not decreased

2023-06-07 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5926: Summary: zeppelin_user_sockets and zeppelin_note_sockets are not decreased Key: ZEPPELIN-5926 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5926 Project

[GitHub] [zeppelin] Reamer commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580598263 Are you sure it is because of this change? I think you have another concurrency problem. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580078356 hi~, I tried to use the above modifications, but now occasionally throw java.nio.file.NoSuchFileException ``` Caused by: java.nio.file.NoSuchFileException: /usr/local/zeppelin-0

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580078089 hi~, I tried to use the above modifications, but now occasionally throw java.nio.file.NoSuchFileException ``` Caused by: java.nio.file.NoSuchFileException: /usr/local/zeppelin-0

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580071482 hi~, I tried to use the above modifications, but now occasionally throw java.nio.file.NoSuchFileException ``` Caused by: java.nio.file.NoSuchFileException: /usr/local/zeppelin-0