[GitHub] [zeppelin] zhugezifang commented on a diff in pull request #4594: [ZEPPELIN-5896]feat:add sql debug feat

zhugezifang commented on code in PR #4594: URL: https://github.com/apache/zeppelin/pull/4594#discussion_r1186640864 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java: ## @@ -28,14 +28,7 @@ import java.net.SocketTimeoutException; import java.net.UR

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4594: [ZEPPELIN-5896]feat:add sql debug feat

huage1994 commented on code in PR #4594: URL: https://github.com/apache/zeppelin/pull/4594#discussion_r1186601161 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java: ## @@ -28,14 +28,7 @@ import java.net.SocketTimeoutException; import java.net.URIS

[GitHub] [zeppelin] jongyoul merged pull request #4592: [ZEPPELIN-5905] Use wildcard generic for job and remove generic for JobListener

jongyoul merged PR #4592: URL: https://github.com/apache/zeppelin/pull/4592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] zhugezifang commented on pull request #4594: [ZEPPELIN-5896]feat:add sql debug feat

zhugezifang commented on PR #4594: URL: https://github.com/apache/zeppelin/pull/4594#issuecomment-1536158697 > @zhugezifang Could you make a screenshot of what this feature looks like? And it's better to add doc in `jdbc.md` ok，i add a doc in jdbc.md -- This is an automated message

[GitHub] [zeppelin] zjffdu commented on pull request #4594: [ZEPPELIN-5896]feat:add sql debug feat

zjffdu commented on PR #4594: URL: https://github.com/apache/zeppelin/pull/4594#issuecomment-1536147257 @zhugezifang Could you make a screenshot of what this feature looks like? And it's better to add doc in `jdbc.md` -- This is an automated message from the Apache Git Service. To respond

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4595: [ZEPPELIN-5907][JUnit 5 Migration] Module zeppelin-interpreter

Reamer commented on code in PR #4595: URL: https://github.com/apache/zeppelin/pull/4595#discussion_r1185898124 ## zeppelin-interpreter/src/test/java/org/apache/zeppelin/cluster/ClusterSingleNodeTest.java: ## @@ -20,21 +20,22 @@ import org.apache.zeppelin.cluster.meta.ClusterMet

[GitHub] [zeppelin] huage1994 commented on pull request #4595: [ZEPPELIN-5907][JUnit 5 Migration] Module zeppelin-interpreter

huage1994 commented on PR #4595: URL: https://github.com/apache/zeppelin/pull/4595#issuecomment-1535934652 LGTM except for some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4595: [ZEPPELIN-5907][JUnit 5 Migration] Module zeppelin-interpreter

huage1994 commented on code in PR #4595: URL: https://github.com/apache/zeppelin/pull/4595#discussion_r1185841009 ## zeppelin-interpreter/src/test/java/org/apache/zeppelin/cluster/ClusterSingleNodeTest.java: ## @@ -20,21 +20,22 @@ import org.apache.zeppelin.cluster.meta.Cluster

[GitHub] [zeppelin] Reamer opened a new pull request, #4595: [ZEPPELIN-5907][JUnit 5 Migration] Module zeppelin-interpreter

Reamer opened a new pull request, #4595: URL: https://github.com/apache/zeppelin/pull/4595 ### What is this PR for? This PR is to migrate the tests in zeppelin-interpreter module from JUnit 4 to JUnit 5, which is a part of [JUnit 5 Migration Plan](https://issues.apache.org/jira/browse/ZE

[jira] [Created] (ZEPPELIN-5907) [JUnit 5 Migration] Module: zeppelin-interpreter

Philipp Dallig created ZEPPELIN-5907: Summary: [JUnit 5 Migration] Module: zeppelin-interpreter Key: ZEPPELIN-5907 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5907 Project: Zeppelin