Reamer commented on PR #4593:
URL: https://github.com/apache/zeppelin/pull/4593#issuecomment-1527517415
Thank you for your participation. I am looking forward to your PullRequest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
zhugezifang commented on PR #4593:
URL: https://github.com/apache/zeppelin/pull/4593#issuecomment-1527513402
> LGTM
thanks, and i also want to add the feature of sql-debug to zeppelin ，it
is a brief description in https://issues.apache.org/jira/browse/ZEPPELIN-5896
--
Th
zhugezifang opened a new pull request, #4593:
URL: https://github.com/apache/zeppelin/pull/4593
### What is this PR for?
This pull request fix the bug of download csv data error
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the
zhugezifang closed pull request #4591: [ZEPPELIN-5898]fix:down csv data error
URL: https://github.com/apache/zeppelin/pull/4591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zhugezifang commented on PR #4591:
URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527297261
> > @Reamer hi，i also want to add this feature into zeppelin，and could I get
your support？
>
> Of course. I was able to reproduce the problem and understood the problem.
Your
Reamer commented on PR #4591:
URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527196813
> @Reamer hi，i also want to add this feature into zeppelin，and could I get
your support？
Of course. I was able to reproduce the problem and understood the problem.
Your change defi
Reamer commented on code in PR #4590:
URL: https://github.com/apache/zeppelin/pull/4590#discussion_r1180032048
##
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java:
##
@@ -162,6 +162,14 @@ public void testLruCache() throws IOException {
noteMa
zhugezifang commented on PR #4591:
URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527116417
> > I do not understand the fix. Could you please explain it.
>
> excuce me，there is a webchat group or other group of zeppelin，we can
discuss it more timely。
>
> and i
zhugezifang commented on PR #4591:
URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527114539
> I don't think it's a specific JSON problem, but rather a delimiter
problem. The CSV is broken because in the JSON example there is a `,` in the
text field and this is also used as
huage1994 commented on PR #4590:
URL: https://github.com/apache/zeppelin/pull/4590#issuecomment-1527113642
The changes look very good. I just have a minor code suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Reamer commented on PR #4592:
URL: https://github.com/apache/zeppelin/pull/4592#issuecomment-1527107097
This PR is dependent on #4582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Reamer opened a new pull request, #4592:
URL: https://github.com/apache/zeppelin/pull/4592
### What is this PR for?
This PR uses generics for the job class. I have not managed to use the
generics for the JobListener class everywhere, so for simplicity I have removed
the generic.
The I
huage1994 commented on code in PR #4590:
URL: https://github.com/apache/zeppelin/pull/4590#discussion_r1180017995
##
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java:
##
@@ -162,6 +162,14 @@ public void testLruCache() throws IOException {
not
Philipp Dallig created ZEPPELIN-5905:
Summary: Polish generics for Job and JobListener
Key: ZEPPELIN-5905
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5905
Project: Zeppelin
Issue
14 matches
Mail list logo
