[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2022-12-09 Thread GitBox
jongyoul commented on code in PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#discussion_r1044995568 ## zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java: ## @@ -18,25 +18,25 @@ import org.apache.zeppelin.conf.ZeppelinConfigu

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2022-12-09 Thread GitBox
jongyoul commented on code in PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#discussion_r1044995483 ## zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/ParagraphTextParserTest.java: ## @@ -136,38 +136,32 @@ public void testParagraphTextQuotedPropertyKeyAn

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2022-12-09 Thread GitBox
jongyoul commented on code in PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#discussion_r1044995443 ## zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/ParagraphTextParserTest.java: ## @@ -136,38 +136,32 @@ public void testParagraphTextQuotedPropertyKeyAn

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2022-12-09 Thread GitBox
jongyoul commented on code in PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#discussion_r1044995362 ## zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java: ## @@ -21,10 +21,11 @@ import org.apache.zeppelin.notebook.exception.NotePathAlr

[GitHub] [zeppelin] jongyoul commented on pull request #4520: [MINOR] Fix Appveyor error

2022-12-09 Thread GitBox
jongyoul commented on PR #4520: URL: https://github.com/apache/zeppelin/pull/4520#issuecomment-1345098798 @Reamer @zjffdu I think it archives its own purpose to make appveyor healthy again :-) -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4537: Bump spring-web from 4.3.0.RELEASE to 6.0.0 in /livy

2022-12-09 Thread GitBox
dependabot[bot] opened a new pull request, #4537: URL: https://github.com/apache/zeppelin/pull/4537 Bumps [spring-web](https://github.com/spring-projects/spring-framework) from 4.3.0.RELEASE to 6.0.0. Release notes Sourced from https://github.com/spring-projects/spring-framework/re

[GitHub] [zeppelin] pan3793 opened a new pull request, #4536: [ZEPPELIN-5867][JDBC] Exclude hbase-server from hive-jdbc

2022-12-09 Thread GitBox
pan3793 opened a new pull request, #4536: URL: https://github.com/apache/zeppelin/pull/4536 ### What is this PR for? This PR proposes to exclude hbase-server from hive-jdbc, because hive-jdbc does not require that, and the transitive deps of hbase-server cause issue on resolving proj

[jira] [Created] (ZEPPELIN-5867) Exclude hbase-server from hive-jdbc

2022-12-09 Thread Cheng Pan (Jira)
Cheng Pan created ZEPPELIN-5867: --- Summary: Exclude hbase-server from hive-jdbc Key: ZEPPELIN-5867 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5867 Project: Zeppelin Issue Type: Improvem

[GitHub] [zeppelin] zenozeng commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-12-09 Thread GitBox
zenozeng commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1344397391 @vineethNaroju As the Flink documentation says, you can move `flink-sql-client*.jar` to the /lib folder. > The /lib directory of the Flink distribution additionally contains vario

[GitHub] [zeppelin] vineethNaroju commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-12-09 Thread GitBox
vineethNaroju commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1344277755 Thank you Jeff for this patch. The patch worked except one issue - with flink interpreter failed to start with below exception as, ``` Caused by: java.lang.NoClassDefFoundErr

[jira] [Created] (ZEPPELIN-5866) Divide checkstyle goal from verify goal

2022-12-09 Thread Jongyoul Lee (Jira)
Jongyoul Lee created ZEPPELIN-5866: -- Summary: Divide checkstyle goal from verify goal Key: ZEPPELIN-5866 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5866 Project: Zeppelin Issue Type

[GitHub] [zeppelin] jongyoul commented on pull request #4520: [MINOR] Fix Appveyor error

2022-12-09 Thread GitBox
jongyoul commented on PR #4520: URL: https://github.com/apache/zeppelin/pull/4520#issuecomment-1344262566 @Reamer BTW, I have checked and found some workarounds, fortunately. Let me make a PR soon. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [zeppelin] Reamer commented on pull request #4520: [MINOR] Fix Appveyor error

2022-12-09 Thread GitBox
Reamer commented on PR #4520: URL: https://github.com/apache/zeppelin/pull/4520#issuecomment-1344258895 > @Reamer BTW, in the case of the core module, does the PR fix them as well? unfortunately not -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4523: [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips

2022-12-09 Thread GitBox
jongyoul commented on code in PR #4523: URL: https://github.com/apache/zeppelin/pull/4523#discussion_r1044415208 ## zeppelin-jupyter-interpreter-shaded/pom.xml: ## @@ -36,6 +36,28 @@ ${project.groupId} zeppelin-jupyter-interpreter ${project.version} +

[GitHub] [zeppelin] jongyoul commented on pull request #4523: [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips

2022-12-09 Thread GitBox
jongyoul commented on PR #4523: URL: https://github.com/apache/zeppelin/pull/4523#issuecomment-1344256983 I tested it failed with aarch64 jdk. Thank you for letting me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4529: [MINOR] Specify branch names for Github action

2022-12-09 Thread GitBox
jongyoul commented on code in PR #4529: URL: https://github.com/apache/zeppelin/pull/4529#discussion_r1044412279 ## .github/workflows/core.yml: ## @@ -1,11 +1,14 @@ name: core + on: push: +branches: Review Comment: I changed it to use `branches-ignores` instead. :-)

[GitHub] [zeppelin] jongyoul commented on pull request #4520: [MINOR] Fix Appveyor error

2022-12-09 Thread GitBox
jongyoul commented on PR #4520: URL: https://github.com/apache/zeppelin/pull/4520#issuecomment-1344244250 @Reamer BTW, in the case of the core module, does the PR fix them as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [zeppelin] Reamer merged pull request #4526: [ZEPPELIN-5863] Warn not to expose the docker daemon to untrusted users

2022-12-09 Thread GitBox
Reamer merged PR #4526: URL: https://github.com/apache/zeppelin/pull/4526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] Reamer commented on pull request #4520: [MINOR] Fix Appveyor error

2022-12-09 Thread GitBox
Reamer commented on PR #4520: URL: https://github.com/apache/zeppelin/pull/4520#issuecomment-1344039188 Please rebase your branch to the current master, PR #4534 has corrected core / interpreter-test-non-core. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4535: Bump qs from 6.5.2 to 6.5.3 in /zeppelin-web-angular

2022-12-09 Thread GitBox
dependabot[bot] opened a new pull request, #4535: URL: https://github.com/apache/zeppelin/pull/4535 Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. Changelog Sourced from https://github.com/ljharb/qs/blob/main/CHANGELOG.md";>qs's changelog. 6.5.3 [Fix] p