[GitHub] [zeppelin] antonvasilev52 commented on pull request #4367: Small typos in Spark introduction

2022-05-13 Thread GitBox
antonvasilev52 commented on PR #4367: URL: https://github.com/apache/zeppelin/pull/4367#issuecomment-1126249032 @zjffdu, updated. I'm sorry that I didn't do it right away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Created] (ZEPPELIN-5737) Deadlock during Interpreter Creation

2022-05-13 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5737: Summary: Deadlock during Interpreter Creation Key: ZEPPELIN-5737 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5737 Project: Zeppelin Issue Typ

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
huage1994 commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1125990383 > @huage1994 Could you add unit test in ZeppelinConfigurationTest? Sure. I would add it. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] zjffdu commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
zjffdu commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1125981646 @huage1994 Could you add unit test in ZeppelinConfigurationTest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
huage1994 commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1125951606 > Thank you but it looks like braking configuration after upgrading it. Do you have any plan to support old configuration in a new version? Otherwise, do users need to change it by han

[GitHub] [zeppelin] Reamer merged pull request #4348: [ZEPPELIN-5712] Improve Interpreter Pod name

2022-05-13 Thread GitBox
Reamer merged PR #4348: URL: https://github.com/apache/zeppelin/pull/4348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] jongyoul commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
jongyoul commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1125928609 Thank you but it looks like braking configuration after upgrading it. Do you have any plan to support old configuration in a new version? Otherwise, do users need to change it by hand?

[GitHub] [zeppelin] huage1994 opened a new pull request, #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
huage1994 opened a new pull request, #4368: URL: https://github.com/apache/zeppelin/pull/4368 ### What is this PR for? This PR is to upport time unit setting in zeppelin conf, such as `5s` ,`3m` ,`1h`. ### What type of PR is it? Feature ### Todos * [ ] - Task

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-05-13 Thread GitBox
Reamer commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r872092418 ## zeppelin-plugins/notebookrepo/mongo/src/main/java/org/apache/zeppelin/notebook/repo/MongoPlugin.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-05-13 Thread GitBox
Reamer commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r872091416 ## zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java: ## @@ -54,11 +57,11 @@ public InterpreterClien