asfgit closed pull request #4322:
URL: https://github.com/apache/zeppelin/pull/4322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
zjffdu commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1082639622
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
Jeff Zhang created ZEPPELIN-5699:
Summary: Trim space in ConfInterpreter
Key: ZEPPELIN-5699
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5699
Project: Zeppelin
Issue Type: Improvement
zjffdu commented on pull request #4334:
URL: https://github.com/apache/zeppelin/pull/4334#issuecomment-1082514458
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zjffdu commented on pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#issuecomment-1082514236
> LGTM but I have an opinion. First of all, I'm not an expert on Flink so
you can freely tell me where I might misunderstand it. I saw the
`Flink113SqlInterpreter` and felt lik
zjffdu commented on a change in pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#discussion_r837454291
##
File path: flink/flink1.12-shims/pom.xml
##
@@ -176,7 +176,7 @@
-unchecked
-deprecation
pjfanning commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081733597
@zjffdu looks like the rerun passed - so it does look like bouncycastle has
no effect
--
This is an automated message from the Apache Git Service.
To respond to the messag
zjffdu closed pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
zjffdu commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081654998
@pjfanning shiro depends on bouncycastle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pjfanning edited a comment on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081652246
@zjffdu you already reverted the bouncycastle upgrade in
https://github.com/apache/zeppelin/commit/49b2e59625f54e29d787e94c8483980a90952014
but it appears that for wh
pjfanning commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081652246
@zjffdu you already reverted the bouncycastle upgrade in
https://github.com/apache/zeppelin/commit/49b2e59625f54e29d787e94c8483980a90952014
but it appears that for when upgr
zjffdu commented on a change in pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#discussion_r837269684
##
File path:
flink/flink-scala-parent/src/main/scala/org/apache/zeppelin/flink/internal/FlinkILoop.scala
##
@@ -101,9 +104,12 @@ class FlinkILoop(
pr
Jeff Zhang created ZEPPELIN-5698:
Summary: Make hadoop3 as default profile
Key: ZEPPELIN-5698
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5698
Project: Zeppelin
Issue Type: Improvemen
zjffdu commented on a change in pull request #4328:
URL: https://github.com/apache/zeppelin/pull/4328#discussion_r837265091
##
File path: docs/interpreter/flink.md
##
@@ -285,7 +285,11 @@ You can also add and set other Flink properties which are
not listed in the tabl
tru
zjffdu commented on pull request #4317:
URL: https://github.com/apache/zeppelin/pull/4317#issuecomment-1081644568
Thanks @pjfanning , I think it is better to separate them in different PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Jeff Zhang created ZEPPELIN-5697:
Summary: Remove old planner support of flink
Key: ZEPPELIN-5697
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5697
Project: Zeppelin
Issue Type: Improv
zjffdu opened a new pull request #4335:
URL: https://github.com/apache/zeppelin/pull/4335
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/contri
17 matches
Mail list logo