[GitHub] [zeppelin] martin-g commented on a change in pull request #4238: ZEPPELIN-5543 Add CircleCI config to test on Linux ARM64

2021-09-27 Thread GitBox
martin-g commented on a change in pull request #4238: URL: https://github.com/apache/zeppelin/pull/4238#discussion_r717272107 ## File path: .circleci/config.yml ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [zeppelin] martin-g commented on a change in pull request #4238: ZEPPELIN-5543 Add CircleCI config to test on Linux ARM64

2021-09-27 Thread GitBox
martin-g commented on a change in pull request #4238: URL: https://github.com/apache/zeppelin/pull/4238#discussion_r717271960 ## File path: .circleci/config.yml ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [zeppelin] martin-g commented on a change in pull request #4238: ZEPPELIN-5543 Add CircleCI config to test on Linux ARM64

2021-09-27 Thread GitBox
martin-g commented on a change in pull request #4238: URL: https://github.com/apache/zeppelin/pull/4238#discussion_r717271114 ## File path: .circleci/config.yml ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [zeppelin] asfgit closed pull request #4236: [ZEPPELIN-5540] fix the unexpected NPE when use hive with Flink

2021-09-27 Thread GitBox
asfgit closed pull request #4236: URL: https://github.com/apache/zeppelin/pull/4236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] zjffdu commented on pull request #4236: [ZEPPELIN-5540] fix the unexpected NPE when use hive with Flink

2021-09-27 Thread GitBox
zjffdu commented on pull request #4236: URL: https://github.com/apache/zeppelin/pull/4236#issuecomment-928895532 Thanks for the contribution @legendtkl LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [zeppelin] Reamer commented on a change in pull request #4238: ZEPPELIN-5543 Add CircleCI config to test on Linux ARM64

2021-09-27 Thread GitBox
Reamer commented on a change in pull request #4238: URL: https://github.com/apache/zeppelin/pull/4238#discussion_r717259172 ## File path: .circleci/config.yml ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agr

[GitHub] [zeppelin] asfgit closed pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.

2021-09-27 Thread GitBox
asfgit closed pull request #4216: URL: https://github.com/apache/zeppelin/pull/4216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] asfgit closed pull request #4230: [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8

2021-09-27 Thread GitBox
asfgit closed pull request #4230: URL: https://github.com/apache/zeppelin/pull/4230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] legendtkl commented on pull request #4236: [ZEPPELIN-5540] fix the unexpected NPE when use hive with Flink

2021-09-27 Thread GitBox
legendtkl commented on pull request #4236: URL: https://github.com/apache/zeppelin/pull/4236#issuecomment-928736693 hi @zjffdu , would you help review this 'tiny' PR? Thanks, Kelu. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [zeppelin] asfgit closed pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

2021-09-27 Thread GitBox
asfgit closed pull request #4233: URL: https://github.com/apache/zeppelin/pull/4233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] jongyoul closed pull request #4234: [ZEPPELIN-5537] Remove code related to ZeppelinHub

2021-09-27 Thread GitBox
jongyoul closed pull request #4234: URL: https://github.com/apache/zeppelin/pull/4234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[GitHub] [zeppelin] martin-g commented on pull request #4238: ZEPPELIN-5543 Add CircleCI config to test on Linux ARM64

2021-09-27 Thread GitBox
martin-g commented on pull request #4238: URL: https://github.com/apache/zeppelin/pull/4238#issuecomment-928212605 Test results could be seen at https://app.circleci.com/pipelines/github/martin-g/zeppelin?branch=zeppelin-5543-use-circle.ci-for-testing-on-linux-arm64 (probably you need to b

[GitHub] [zeppelin] martin-g opened a new pull request #4238: ZEPPELIN-5543 Add CircleCI config to test on Linux ARM64

2021-09-27 Thread GitBox
martin-g opened a new pull request #4238: URL: https://github.com/apache/zeppelin/pull/4238 ### What is this PR for? Execute basic/smoke tests on Linux ARM64 at CircleCI. ### What type of PR is it? Improvement ### Todos * [ ] - Add more builds ?! E.g. `hadoop3'

[jira] [Created] (ZEPPELIN-5543) Introduce testing on CircleCI to cover Linux ARM64

2021-09-27 Thread Martin Tzvetanov Grigorov (Jira)
Martin Tzvetanov Grigorov created ZEPPELIN-5543: --- Summary: Introduce testing on CircleCI to cover Linux ARM64 Key: ZEPPELIN-5543 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5543 P

[GitHub] [zeppelin] martin-g opened a new pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS

2021-09-27 Thread GitBox
martin-g opened a new pull request #4237: URL: https://github.com/apache/zeppelin/pull/4237 ### What is this PR for? Replaces the usage of PhantomJS for the JavaScript tests with headless Firefox. PhantomJS is not maintained since few years. Using a real browser will make the t

[jira] [Created] (ZEPPELIN-5542) Use headless Firefox for e2e tests instead of PhantomJS

2021-09-27 Thread Martin Tzvetanov Grigorov (Jira)
Martin Tzvetanov Grigorov created ZEPPELIN-5542: --- Summary: Use headless Firefox for e2e tests instead of PhantomJS Key: ZEPPELIN-5542 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5542

[GitHub] [zeppelin] legendtkl opened a new pull request #4236: [ZEPPELIN-5540] fix the unexpected NPE when use hive with Flink

2021-09-27 Thread GitBox
legendtkl opened a new pull request #4236: URL: https://github.com/apache/zeppelin/pull/4236 ### What is this PR for? When we enable hive in Flink interpreter, we encounter the unexpected NPE. The root cause is the value `properties.getOrDefault("HIVE_CONF_DIR", System.getenv("HIVE_CONF

[GitHub] [zeppelin] zjffdu commented on pull request #4230: [ZEPPELIN-5525] Python vanillar interpreter doesn't' work in Python 3.8

2021-09-27 Thread GitBox
zjffdu commented on pull request #4230: URL: https://github.com/apache/zeppelin/pull/4230#issuecomment-927667641 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] zjffdu commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.

2021-09-27 Thread GitBox
zjffdu commented on pull request #4216: URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927667422 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] zjffdu commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.

2021-09-27 Thread GitBox
zjffdu commented on pull request #4216: URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927659391 CI is passed now, thanks @NicolasGong Sometimes some tests will still fail due to network or other unknown reason, usually rerun will turn CI to green -- This is an automated

[GitHub] [zeppelin] Reamer commented on a change in pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary

2021-09-27 Thread GitBox
Reamer commented on a change in pull request #4235: URL: https://github.com/apache/zeppelin/pull/4235#discussion_r716441898 ## File path: flink/flink-scala-parent/pom.xml ## @@ -862,9 +862,6 @@ maven-enforcer-plugin - -maven-dependency-plu

[GitHub] [zeppelin] Reamer commented on a change in pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary

2021-09-27 Thread GitBox
Reamer commented on a change in pull request #4235: URL: https://github.com/apache/zeppelin/pull/4235#discussion_r716440815 ## File path: zeppelin-interpreter/pom.xml ## @@ -231,12 +231,6 @@ true - - -org.apache.maven.plugins -ma

[GitHub] [zeppelin] Reamer commented on a change in pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary

2021-09-27 Thread GitBox
Reamer commented on a change in pull request #4235: URL: https://github.com/apache/zeppelin/pull/4235#discussion_r716439732 ## File path: spark/interpreter/pom.xml ## @@ -517,60 +517,6 @@ - - - -maven-dependency-plugin - -

[GitHub] [zeppelin] Reamer commented on a change in pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary

2021-09-27 Thread GitBox
Reamer commented on a change in pull request #4235: URL: https://github.com/apache/zeppelin/pull/4235#discussion_r716438132 ## File path: spark/interpreter/pom.xml ## @@ -517,60 +517,6 @@ - - - -maven-dependency-plugin - -

[GitHub] [zeppelin] Reamer opened a new pull request #4235: [ZEPPELIN-5541] Remove maven-dependency-plugin from pom.xml where it not necessary

2021-09-27 Thread GitBox
Reamer opened a new pull request #4235: URL: https://github.com/apache/zeppelin/pull/4235 ### What is this PR for? This PR removes unnecessary calls of maven-dependency-plugin. ### What type of PR is it? - Improvement ### What is the Jira issue? * https://issues.a

[jira] [Created] (ZEPPELIN-5541) Followup Remove unnecessary maven-dependency-plugin maven plugin call

2021-09-27 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5541: Summary: Followup Remove unnecessary maven-dependency-plugin maven plugin call Key: ZEPPELIN-5541 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5541 Pro

[GitHub] [zeppelin] martin-g commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

2021-09-27 Thread GitBox
martin-g commented on pull request #4233: URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927580944 @zjffdu I will prepare a PR for testing on Linux ARM64 at CircleCI! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [zeppelin] NicolasGong commented on pull request #4216: [ZEPPELIN-5510]Thread leakage in JobManager of flink interpreter.

2021-09-27 Thread GitBox
NicolasGong commented on pull request #4216: URL: https://github.com/apache/zeppelin/pull/4216#issuecomment-927558996 Sorry, I rebase the code and fixed a problem. But I don't know the reason why other CI failed. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [zeppelin] zjffdu commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

2021-09-27 Thread GitBox
zjffdu commented on pull request #4233: URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927581847 Thanks @martin-g I will merge this PR if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use