[GitHub] [zeppelin] zjffdu opened a new pull request #4195: save

2021-08-01 Thread GitBox
zjffdu opened a new pull request #4195: URL: https://github.com/apache/zeppelin/pull/4195 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contri

Re: [GitHub] [zeppelin] zjffdu opened a new pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-01 Thread denny wong
Can you add a logic to check if the max result size is reached?  If so, print out a warning message.  Essentially, the same behavior as found in the python interpreter.         if exceed_limit:            print("\n%html Results are limited by {}.".format(self.max_result)) ThanksDenny On S

[GitHub] [zeppelin] asfgit closed pull request #4184: [ZEPPELIN-5465] SERVICE_DOMAIN may be null while Zeppelin server is running outside k8s

2021-08-01 Thread GitBox
asfgit closed pull request #4184: URL: https://github.com/apache/zeppelin/pull/4184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] asfgit closed pull request #4188: [ZEPPELIN-5471] spark yarn app is not stopped when cancel button is clicked

2021-08-01 Thread GitBox
asfgit closed pull request #4188: URL: https://github.com/apache/zeppelin/pull/4188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] asfgit closed pull request #4190: [ZEPPELIN-5470] set statement may not work when key value around quotes

2021-08-01 Thread GitBox
asfgit closed pull request #4190: URL: https://github.com/apache/zeppelin/pull/4190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] Reamer commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname

2021-08-01 Thread GitBox
Reamer commented on pull request #4192: URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-890540495 "Cluster.local" as you mentioned is not always correct. I would prefer either a domain value that can be configured or add documentation that you need to configure your cluster

[GitHub] [zeppelin] zjffdu commented on pull request #4186: [ZEPPELIN-5468]Fast return when invalid ticket of no session case

2021-08-01 Thread GitBox
zjffdu commented on pull request #4186: URL: https://github.com/apache/zeppelin/pull/4186#issuecomment-890526987 @aib628 Recently CI seems unable recently, we may need to wait for a while until CI become stable. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [zeppelin] aib628 commented on pull request #4186: [ZEPPELIN-5468]Fast return when invalid ticket of no session case

2021-08-01 Thread GitBox
aib628 commented on pull request #4186: URL: https://github.com/apache/zeppelin/pull/4186#issuecomment-89051 > @aib628 Just force push will trigger the CI, and BTW besides the NPE in log, is there any user experience effect of this issue ?? @zjffdu no, log only -- This is an a

[GitHub] [zeppelin] zjffdu commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname

2021-08-01 Thread GitBox
zjffdu commented on pull request #4192: URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-890476547 @ebuildy Thanks for the clarification, this sounds like convention, right ? Anyway, this PR LGTM -- This is an automated message from the Apache Git Service. To respond to th