[GitHub] [zeppelin] dannycranmer commented on pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer commented on pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-817891879 Looks like I have a flaky UI test, will address -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [zeppelin] dannycranmer commented on pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer commented on pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-817891494 > I see that you have made changes in the `zeppelin-web` submodule. We a newer frontend submodule `zeppelin-web-angular`. Unfortunately, I am not a NodeJS developer, so I

[GitHub] [zeppelin] dannycranmer commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r611713414 ## File path: zeppelin-web/src/app/notebook/notebook.controller.js ## @@ -539,11 +539,23 @@ function NotebookCtrl($scope, $route, $routeParams, $lo

[GitHub] [zeppelin] Reamer commented on pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#issuecomment-817859179 I will merge this PR into master and branch-0.9 on Thursday if no further comments are received. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] Reamer commented on pull request #4091: [ZEPPELIN-5319] Incorrect markdown in the documentation of sap interpreter

Reamer commented on pull request #4091: URL: https://github.com/apache/zeppelin/pull/4091#issuecomment-817857107 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[jira] [Created] (ZEPPELIN-5321) Missing links of some interpreters in index page and link menu.

Myoungdo Park created ZEPPELIN-5321: --- Summary: Missing links of some interpreters in index page and link menu. Key: ZEPPELIN-5321 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5321 Project: Z

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

cuspymd commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r611663144 ## File path: zeppelin-web/src/app/notebook/notebook.controller.js ## @@ -539,11 +539,23 @@ function NotebookCtrl($scope, $route, $routeParams, $locatio

[GitHub] [zeppelin] Reamer commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

Reamer commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r611652026 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java ## @@ -225,6 +228,8 @@ public void moveNote(String noteId,

[GitHub] [zeppelin] dannycranmer opened a new pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer opened a new pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092 ### What is this PR for? When a user renames a note Zeppelin does not check for existing notes with the same name/path. This can result in errors as multiple notes can have conflicting paths.