[GitHub] [zeppelin] zjffdu commented on pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

zjffdu commented on pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#issuecomment-782992021 Thanks for the contribution @Kimahriman Is doc here needs to be updated ? http://zeppelin.apache.org/docs/0.9.0/setup/security/shiro_authentication.html#knox-sso --

[GitHub] [zeppelin] asfgit closed pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions

asfgit closed pull request #4054: URL: https://github.com/apache/zeppelin/pull/4054 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] Kimahriman commented on a change in pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

Kimahriman commented on a change in pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826989 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java ## @@ -247,6 +248,9 @@ public boolean isAuthe

[GitHub] [zeppelin] Kimahriman commented on a change in pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

Kimahriman commented on a change in pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826864 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java ## @@ -138,8 +139,8 @@ private String extract

[GitHub] [zeppelin] Kimahriman commented on a change in pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

Kimahriman commented on a change in pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826741 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/realm/jwt/KnoxJwtRealm.java ## @@ -241,7 +228,6 @@ protected AuthorizationInfo doGet

[GitHub] [zeppelin] Kimahriman commented on a change in pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

Kimahriman commented on a change in pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826676 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/realm/jwt/KnoxJwtRealm.java ## @@ -83,14 +78,6 @@ @Override protected void onIn

[GitHub] [zeppelin] Kimahriman commented on a change in pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

Kimahriman commented on a change in pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826527 ## File path: conf/shiro.ini.template ## @@ -66,8 +66,6 @@ user3 = password4, role2 #knoxJwtRealm.cookieName = hadoop-jwt #knoxJwtRealm.publicKeyPat

[GitHub] [zeppelin] Kimahriman opened a new pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

Kimahriman opened a new pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059 ### What is this PR for? This PR aims to add support for Knox groups in ShiroAuthenticationService.getAssociatedRoles. This allows Knox realm groups (which uses hadoop groups under the hood) to

[jira] [Created] (ZEPPELIN-5258) Add Knox realm support to ShiroAuthenticationService.getAssociatedRoles

Adam Binford created ZEPPELIN-5258: -- Summary: Add Knox realm support to ShiroAuthenticationService.getAssociatedRoles Key: ZEPPELIN-5258 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5258 Proje

[GitHub] [zeppelin] zjffdu opened a new pull request #4058: [ZEPPELIN-5257] Refactoring of ExecutionContext

zjffdu opened a new pull request #4058: URL: https://github.com/apache/zeppelin/pull/4058 ### What is this PR for? This PR is to refactoring ExecutionContext: move its creation to `Note`, because most of fields of ExecutionContext is from Note. Moving it to `Note` (Note#getExecution