Jeff Zhang created ZEPPELIN-3365:
Summary: Load interpreter-setting.json in RemoteInterpreterServer
Key: ZEPPELIN-3365
URL: https://issues.apache.org/jira/browse/ZEPPELIN-3365
Project: Zeppelin
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2831
.. and I've reviewed all PRs and left one or two comments.
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2891
thanks, sounds like that could be useful.
what do you think about "secret" management?
also for template I think we should match the other way, where we have a
longer discussion: #2834
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2831
of course, let's do the right thing. feel free to ping me in all PR, but
generally I should get to it within a day, at least for the next few months. :)
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2587
ok thanks, didn't realize it's been 7 months... :)
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2892
seems like test fail for unrelated reason - is it out of date or something?
```
[WARNING] The requested profile "hadoop2" could not be activated because it
does not exist.
[ERROR] F
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2893
merging if no more comment
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2587
@felixcheung It is documented here.
https://github.com/apache/zeppelin/blame/master/docs/interpreter/livy.md#L219
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2834
Yes, it is safe for me merge it into branch-0.8
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2831
Thanks @felixcheung for review, these issues block the 0.8 release and
recently there's no much review bandwidth in community, that's why I didn't
wait for more views. Will wait for more long time
GitHub user HorizonNet opened a pull request:
https://github.com/apache/zeppelin/pull/2893
ZEPPELIN-3161. Fixed Checkstyle issues in lens module
### What is this PR for?
Fixes the Checkstyle issues in the lens module.
### What type of PR is it?
Improvement
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2587
still, I think this feature is distinctive enough that we should document
and bring some visibility (even if it just works)
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2793
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2831
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2837
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2836
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2843
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2838
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2844
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2861
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2846
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2847
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2865
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2866
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2869
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2874
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2871
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2875
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2877
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2878
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2882
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2887
hey @zjffdu thanks for making all these improvements, could we make sure
there is at least one review before merging?
@Leemoonsoo
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2834
@zjffdu do we still merge commits to branch-0.8?
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2834
@zjffdu Thanks for your review - that was very helpful.
Have fixed all the issues - please see [details added after your
comment](https://github.com/apache/zeppelin/pull/2834/files/
Jeff Zhang created ZEPPELIN-3364:
Summary: Followup of ZEPPELIN-3362, improve ZeppelinContext & add
more test
Key: ZEPPELIN-3364
URL: https://issues.apache.org/jira/browse/ZEPPELIN-3364
Project: Zeppe
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2890
Thanks for the review @felixcheung , will do the improvement in another PR
---
36 matches
Mail list logo
