[GitHub] zeppelin issue #2482: [ZEPPELIN-2765] Configurable X-FRAME-OPTIONS for Zeppe...

2017-07-11 Thread krishna-pandey
Github user krishna-pandey commented on the issue: https://github.com/apache/zeppelin/pull/2482 @felixcheung Thanks for the review. Fixed the value. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

2017-07-11 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2460 Cool! Thanks @1ambda for checking! I also just checked it works well on mobile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

2017-07-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 and works well in mobile (iphone 6s chrome, sarari) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

2017-07-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 Deployed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #2460: [gh-pages] fix hover event in technologies sect...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #2467: [ZEPPELIN-2730] compare with maxLength after getting a...

2017-07-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2467 Thanks @gaoyang143 for the fix. LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2485: [ZEPPELIN-2758]. NumberFormatException on importing no...

2017-07-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2485 @karuppayya I remove `NotebookTypeAdapterFactory.java` which I think is not necessary. Let me know your concern. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] zeppelin issue #2238: 0.7.1 with ssl

2017-07-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2238 They might be flaky tests. Could you retry failed jobs and see if it goes green? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin pull request #2486: [ZEPPELIN-2768]. Bump up Spark version to 2.2.0

2017-07-11 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2486 [ZEPPELIN-2768]. Bump up Spark version to 2.2.0 ### What is this PR for? Spark 2.2.0 is just released, this PR is to support spark 2.2.0. ### What type of PR is it? [Improvement]

[jira] [Created] (ZEPPELIN-2768) Bump up Spark version to 2.2.0

2017-07-11 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2768: Summary: Bump up Spark version to 2.2.0 Key: ZEPPELIN-2768 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2768 Project: Zeppelin Issue Type: Improvement

[GitHub] zeppelin pull request #2485: [ZEPPELIN-2758]. NumberFormatException on impor...

2017-07-11 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2485 [ZEPPELIN-2758]. NumberFormatException on importing notebook ### What is this PR for? This is due to the custom TypeAdapter for Paragraph. I don't know why we introduce it. To me it is no

[GitHub] zeppelin issue #2481: [HOTFIX][ZEPPELIN-2760] fix JDBC regression caused aft...

2017-07-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2481 @herval and @felixcheung Thank you for the review. Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] zeppelin issue #2471: [ZEPPELIN-2744] [minor] Increase error handling in JDB...

2017-07-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2471 Sure, I see your point, will close this, and mark ZEPPELIN-2744 works as designed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2238: 0.7.1 with ssl

2017-07-11 Thread instaclustr-oss
Github user instaclustr-oss commented on the issue: https://github.com/apache/zeppelin/pull/2238 Hi @Leemoonsoo Sorry for taking awhile to setup the CI. Now that I have, I see some jobs fail. What should I do about it? Thanks! --- If your project is set up for it,

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 all tests passing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2484 This is the basic set of functionality needed to start monitoring some common metrics - Comments & observations welcome! --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2478: [ZEPPELIN-2761] - Neo4j Interpreter

2017-07-11 Thread jexp
Github user jexp commented on the issue: https://github.com/apache/zeppelin/pull/2478 I looked through the code and the UX and can confirm that this is great work from a Neo4j point of view. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

2017-07-11 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 yes of course @felixcheung , basically I'm exposing through maven properties the ability for users to customize where to download from certain packets that are normally downloaded from very speci

[jira] [Created] (ZEPPELIN-2767) Loading scatter chart in chrome, safari freezes the application - when show tables command is executed

2017-07-11 Thread jahira ibrahim (JIRA)
jahira ibrahim created ZEPPELIN-2767: Summary: Loading scatter chart in chrome, safari freezes the application - when show tables command is executed Key: ZEPPELIN-2767 URL: https://issues.apache.org/jira/brow

[GitHub] zeppelin issue #2480: [ZEPPELIN-1249] build all submodules w/ the same scala...

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2480 Regarding verification, how do you suggest I go about that? We've been using this setup internally for some time, but we only use a few of the interpreters (spark, scalding, jdbc, md) - not sure if

[GitHub] zeppelin pull request #2484: [ZEPPELIN-2711] [WIP] basic metrics for paragra...

2017-07-11 Thread herval
GitHub user herval opened a pull request: https://github.com/apache/zeppelin/pull/2484 [ZEPPELIN-2711] [WIP] basic metrics for paragraphs & notebook view/create/run ### What is this PR for? This exposes JMX metrics for a few operations on Zeppelin. The first step here is t

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-11 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Tested and LGTM! It looks cool that when a `writers` logins a note, it shows report mode. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] zeppelin issue #2481: [HOTFIX][ZEPPELIN-2760] fix JDBC regression caused aft...

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2481 oh, Indeed. There's some inheritance there 😶 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] zeppelin issue #2481: [HOTFIX][ZEPPELIN-2760] fix JDBC regression caused aft...

2017-07-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2481 Well, any test case calling `open()` will hit `isKerboseEnabled()`, and in `JdbcInterpreterTest` when ever `isKerboseEnabled` function is called will returning false all the time.

[GitHub] zeppelin issue #2481: [HOTFIX][ZEPPELIN-2760] fix JDBC regression caused aft...

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2481 I actually don't see any test on `JdbcInterpreterTest` covering that code path at all - I think the test suite is passing simply because that bit is not tested, and feel it should be --- If your

[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...

2017-07-11 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2477 [ZEPPELIN-2342] Improving Test Environment for zeppelin-web (e2e, coverage) ### What is this PR for? Improved testing environment for zeppelin-web - added `test:watch` command f

[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...

2017-07-11 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

2017-07-11 Thread andreaTP
GitHub user andreaTP reopened a pull request: https://github.com/apache/zeppelin/pull/2483 [ZEPPELIN-2766] Make online resources url configurable at compile time ### What is this PR for? At compile time Zeppelin is downloading several external resources. I want to be able to

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

2017-07-11 Thread andreaTP
Github user andreaTP closed the pull request at: https://github.com/apache/zeppelin/pull/2483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-11 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2448 @zjffdu yeah, the renaming would be done probably on saving which would apply if user enters note, and does some action so that save->conversion (rename) is initiated. This would work furth

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

2017-07-11 Thread andreaTP
GitHub user andreaTP opened a pull request: https://github.com/apache/zeppelin/pull/2483 [ZEPPELIN-2766] Make online resources url configurable at compile time ### What is this PR for? At compile time Zeppelin is downloading several external resources. I want to be able to pr

[jira] [Created] (ZEPPELIN-2766) Make online resources url configurable at compile time

2017-07-11 Thread Andrea Peruffo (JIRA)
Andrea Peruffo created ZEPPELIN-2766: Summary: Make online resources url configurable at compile time Key: ZEPPELIN-2766 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2766 Project: Zeppelin

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2448 How about do the renaming in saving ? We just need to save to the new file and delete the old note file. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-11 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2448 @Leemoonsoo @1ambda @zjffdu I wanted to have opinion on the note conversion strategy. lazy strategy - converting when note is renamed, vs aggressive - converting all notes when starting zep

[GitHub] zeppelin issue #2482: [ZEPPELIN-2765] Configurable X-FRAME-OPTIONS for Zeppe...

2017-07-11 Thread krishna-pandey
Github user krishna-pandey commented on the issue: https://github.com/apache/zeppelin/pull/2482 @Leemoonsoo, @felixcheung, @jongyoul, @prabhjyotsingh Please help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] zeppelin pull request #2482: [ZEPPELIN-2765] Configurable X-FRAME-OPTIONS fo...

2017-07-11 Thread krishna-pandey
GitHub user krishna-pandey opened a pull request: https://github.com/apache/zeppelin/pull/2482 [ZEPPELIN-2765] Configurable X-FRAME-OPTIONS for Zeppelin ### What is this PR for? The X-Frame-Options HTTP response header can be used to indicate whether or not a browser should be a

[jira] [Created] (ZEPPELIN-2765) Configurable X-FRAME-OPTIONS for Zeppelin

2017-07-11 Thread Krishna Pandey (JIRA)
Krishna Pandey created ZEPPELIN-2765: Summary: Configurable X-FRAME-OPTIONS for Zeppelin Key: ZEPPELIN-2765 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2765 Project: Zeppelin Issu

[GitHub] zeppelin issue #2481: [HOTFIX][ZEPPELIN-2760] fix JDBC regression caused aft...

2017-07-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2481 @herval The reason this exception didn't get caught with any of the existing test cases is because this particular dependency (for UserGroupInformation) is marked as `provided` (https://gi

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 @Leemoonsoo @1ambda @felixcheung @prabhjyotsingh Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-11 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Good! Let me test it out agian! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2329 @jongyoul I still could not get shell interpreter work in yarn mode. But this time it is due to AM fail to launch. Here's the log in AM container. ``` Error: Could not find or load main clas

[GitHub] zeppelin pull request #2459: [ZEPPELIN-2716] Change the default value of zep...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Created] (ZEPPELIN-2764) Change all links from ZeppelinHub to Zepl

2017-07-11 Thread Khalid Huseynov (JIRA)
Khalid Huseynov created ZEPPELIN-2764: - Summary: Change all links from ZeppelinHub to Zepl Key: ZEPPELIN-2764 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2764 Project: Zeppelin Is