[GitHub] zeppelin issue #2459: [ZEPPELIN-2716] Change the default value of zeppelin.l...

2017-07-02 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/zeppelin/pull/2459 CC @zjffdu , please help to review, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] zeppelin pull request #2459: [ZEPPELIN-2716] Change the default value of zep...

2017-07-02 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/zeppelin/pull/2459 [ZEPPELIN-2716] Change the default value of zeppelin.livy.displayAppInfo to true ### What is this PR for? Since it is quite useful to expose the application info for user to monitor a

[jira] [Created] (ZEPPELIN-2716) Change default of zeppelin.livy.displayAppInfo to true

2017-07-02 Thread Saisai Shao (JIRA)
Saisai Shao created ZEPPELIN-2716: - Summary: Change default of zeppelin.livy.displayAppInfo to true Key: ZEPPELIN-2716 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2716 Project: Zeppelin

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-07-02 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2268 1. Please resolve the conflict. 2. Left a minor comment please check that. 3. Tested locally and works well with 6 newly added types. 4. Backward compatibility will be handed by the `co

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 @zjffdu Thanks, Jeff for this kind review. I've addressed your comments and will handle some suggestion, too. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] zeppelin issue #2272: ZEPPELIN-2397. Add toJson and fromJson method for seri...

2017-07-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2272 Thanks @jongyoul Will merge it if no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] zeppelin pull request #2458: Zeppelin 2701

2017-07-02 Thread ebuildy
GitHub user ebuildy opened a pull request: https://github.com/apache/zeppelin/pull/2458 Zeppelin 2701 ### What is this PR for? From https://issues.apache.org/jira/browse/ZEPPELIN-2701, this set a HTML title for notebook page, very good when you have multiple tabs opened.

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-07-02 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2374 this is ready for more review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] zeppelin issue #2272: ZEPPELIN-2397. Add toJson and fromJson method for seri...

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2272 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 What I meant is a kind of selenium test. And I saw it before and it will be useful for testing yarn cluster manager itself. I'll try to add it. --- If your project is set up for it, you can rep

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2329 Not sure what integration test you mean ? Do you mean selenium test ? Actually `MiniYarnCluster` will launch a mini yarn cluster locally, and you can submit jobs to this mini cluster. You can refer

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 Added simple descriptions :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 @zjffdu Thanks for the quick reply. I'll add javadoc for describing it simply. but concerning the unit test, this feature need integration test so I'm not sure if unit test is useful or not. Do y

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2329 @jongyoul Could you add more javadoc on these new classes and write a simple summary about the design so that it is easier for other people to review it ? And I would suggest you to add un

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2440 I got it. I didn't recognize actual username is "anonymous" in production case. If it can be, it will be a problem. --- If your project is set up for it, you can reply to this email and have you

[GitHub] zeppelin pull request #2403: ZEPPELIN-2637: Make useLegacySql configurable, ...

2017-07-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2418 @zjffdu Sounds good. I totally agree with your point of view. We need to add pushing way from interpreter to server, and also abstract that layer carefully to guess most of situation. This is a k

[GitHub] zeppelin issue #2438: [ZEPPELIN-2693] Test: interpreter mode action test

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2438 LGTM. Thanks for making test. Will merge it there's no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 CI already has been passed: https://travis-ci.org/jongyoul/zeppelin/builds/249265535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2329 Ready to review. - Introduced `zeppelin-cluster/common` for cluster manager and its factory class - Added hadoop related setting in `dependecyManagement` of root `pom.xml` --- If yo

[GitHub] zeppelin pull request #2453: [ZEPPELIN-2659] Let WebEnvironment initialize S...

2017-07-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #2454: [ZEPPELIN-2710] Programmatically update progres...

2017-07-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #2452: [ZEPPELIN-2706] Fix unable to remove selected k...

2017-07-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-07-02 Thread cfries
Github user cfries commented on the issue: https://github.com/apache/zeppelin/pull/2440 Hi @jongyoul : I don't understand your comment. You can have "anonymous" when shirt is on. This is even in the shiro example (note: If I understood the shiro example correctly: until the user is no

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-07-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2440 I don't know the purpose of this PR. If username is anonymous, it means shiro is off. What's your intention? --- If your project is set up for it, you can reply to this email and have your reply