JdbcInterpreter might be too generic

2017-05-23 Thread Jeff Zhang
The current JdbcInterpreter implementation seems too generic for me. Two main reasons 1. The logic of executing sql in JdbcInterpeter is a little weird. Here's is what jdbc interpreter would do for "%jdbc(mysql) show tables" The script part is actually `(mysql) show tables` rather than `show t

[GitHub] zeppelin pull request #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backsl...

2017-05-23 Thread tinkoff-dwh
Github user tinkoff-dwh closed the pull request at: https://github.com/apache/zeppelin/pull/2347 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backsl...

2017-05-23 Thread tinkoff-dwh
GitHub user tinkoff-dwh reopened a pull request: https://github.com/apache/zeppelin/pull/2347 [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash) ### What is this PR for? Fix of parser to correctly parse backslash in quotes. ### What type of PR is it? Bug Fix

[jira] [Created] (ZEPPELIN-2579) Fix the error message when interpreter is not configured in notebook

2017-05-23 Thread Yesha Vora (JIRA)
Yesha Vora created ZEPPELIN-2579: Summary: Fix the error message when interpreter is not configured in notebook Key: ZEPPELIN-2579 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2579 Projec

[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...

2017-05-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1577 Any updated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2343 \cc @cloverhearts @astroshim --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2355: [ZEPPELIN-2573] Improve navbar style

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2355 Merge to master if no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2356 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2357: [ZEPPELIN-2429] Improve `import notebook` dialog style

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2357 LGTM and merge to master if no further comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2358: [ZEPPELIN-2428] Improve `create new note` dialog style

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2358 LGTM and merge to master if no further comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2359: [ZEPPELIN-2575] Improve `rename note` dialog style

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2359 LGTM and merge to master if no further comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2360: [ZEPPELIN-2574] Improve `about` dialog style

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2360 LGTM and Merge to master if no further comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2362: [ZEPPELIN-2469] HeliumBundleFactoryTest fails on Travi...

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2362 Flaky test failure https://issues.apache.org/jira/browse/ZEPPELIN-2361 is not related to this contribution. ``` Tests in error: ParagraphActionsIT.testRunOnSelectionChange:3

[GitHub] zeppelin issue #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in focuse...

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2361 Tested and LGTM. Merge to master if no further comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2338: [ZEPPELIN-2122] Add execution time for Spell

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2338 LGTM and merge to master if no further comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2338: [ZEPPELIN-2122][WIP] Add execution time for Spell

2017-05-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2338 @Leemoonsoo No. I have just changed the title again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] zeppelin issue #2338: [ZEPPELIN-2122][WIP] Add execution time for Spell

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2338 @1ambda is this pr WIP? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] zeppelin issue #2363: [ZEPPELIN-2152] Added proxy config support in Helium b...

2017-05-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2363 One more suggestion. Can we support proxy for helium registry file? https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumOnlineRegi

[GitHub] zeppelin issue #2341: ZEPPELIN-2543: Add ability to change the log level at ...

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2341 Thanks @karuppayya for the contribution! LGTM and merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] zeppelin issue #2351: [ZEPPELIN-2544] clean task doesn't work in zeppelin-we...

2017-05-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2351 ping @jongyoul --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2356 Good! What about others? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] zeppelin issue #2363: [ZEPPELIN-2152] Added proxy config support in Helium b...

2017-05-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2363 Can we add documentation for this? under the security section or somewhere appropriate. ![image](https://cloud.githubusercontent.com/assets/4968473/26378753/ec02b244-4050-11e7-9701-ffa65eb

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2326 Thanks @vipul1409 for great contribution. Thanks @1ambda for the review. Merge to master if no further discussions. --- If your project is set up for it, you can reply to this emai

[jira] [Created] (ZEPPELIN-2578) Angular variable change in frontend is not propagated to other paragraphs angular display.

2017-05-23 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-2578: --- Summary: Angular variable change in frontend is not propagated to other paragraphs angular display. Key: ZEPPELIN-2578 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2578

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Tested and works well (both in frontend, backend angular APIs). LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry

2017-05-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2349 If we have both, then it's better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry

2017-05-23 Thread necosta
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2349 Thanks @1ambda, Allow me to disagree :) In my opinion should be: "I hope we have a proxy option as well as configurations for those URLs" The advantage of having configurable URLs is that i

[GitHub] zeppelin pull request #2363: [ZEPPELIN-2152] Added proxy config support in H...

2017-05-23 Thread necosta
GitHub user necosta opened a pull request: https://github.com/apache/zeppelin/pull/2363 [ZEPPELIN-2152] Added proxy config support in Helium bundle factory ### What is this PR for? Proxy configuration implementation in Helium bundle factory. Used by Node, NPM and YarnPkg install

[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry

2017-05-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2349 Personally, I hope we have a proxy option instead of configurations for those URLs. That's because, it's hard to configure every URLs for users. (not scalable solution) There might be more URLs

[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Tried the above: With multiple queries; https://cloud.githubusercontent.com/assets/674497/26358329/d46cf470-3fef-11e7-9afc-76e3bb448270.png";> With single query; htt

[GitHub] zeppelin pull request #2349: [ZEPPELIN-2214] Set npm installer default npm r...

2017-05-23 Thread necosta
GitHub user necosta reopened a pull request: https://github.com/apache/zeppelin/pull/2349 [ZEPPELIN-2214] Set npm installer default npm registry ### What is this PR for? Complements ZEPPELIN-2278, this is a fix for "connection timeout" bug when trying to run "npm install" behind

[GitHub] zeppelin pull request #2349: [ZEPPELIN-2214] Set npm installer default npm r...

2017-05-23 Thread necosta
Github user necosta closed the pull request at: https://github.com/apache/zeppelin/pull/2349 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-23 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 if jdbc driver does not implement this method (getMoreResults), it will work like you said will return the first result --- If your project is set up for it, you can reply to this email and h

[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Sure, I do see this working for Postgres as posted in the screenshot, do you think this will work for rest of the data sources listed here http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/int

[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-23 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 another solution, but I think it's better --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] zeppelin issue #2357: [ZEPPELIN-2429] Improve `import notebook` dialog style

2017-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2357 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Yes, correct. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s