[GitHub] zeppelin issue #2293: [ZEPPELIN-2461] Masking Jetty Server version with User...

2017-05-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2293 Will merge this to master if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-05-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 Thank you @felixcheung. Will merge this to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] zeppelin pull request #2307: [HOTFIX]. Minor doc fix for back-end-angular.md

2017-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Re: Windows Build Support

2017-05-02 Thread Jeff Zhang
Make sense for option 2 moon soo Lee 于2017年5月3日周三 上午9:21写道: > Moving thread to dev@ > > Currently CI on pullrequest is > > - Individual contributor runs Travis - CI > - ASF's Jenkins connected to Apache Zeppelin github repo, and get > information from each contributor's Travis build. > - ASF'

Re: Windows Build Support

2017-05-02 Thread moon soo Lee
Moving thread to dev@ Currently CI on pullrequest is - Individual contributor runs Travis - CI - ASF's Jenkins connected to Apache Zeppelin github repo, and get information from each contributor's Travis build. - ASF's Appveyor build each pullrequest. CI on branch (master, branch-0.7, ...) is

[GitHub] zeppelin issue #2296: [ZEPPELIN-2463] Avoid Locking interpreterSettings duri...

2017-05-02 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2296 @Leemoonsoo , Could you please take a look at this change ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #2310: ZEPPELIN-2484 do a Null check before calling tr...

2017-05-02 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/2310 ZEPPELIN-2484 do a Null check before calling trim on paragraph's text ### What is this PR for? Prevent NullPointerException during check to determine whether a new paragraph needs to adde

[jira] [Created] (ZEPPELIN-2484) NullPointerException in addNewParagraphIfLastParagraphIsExecuted

2017-05-02 Thread Benoy Antony (JIRA)
Benoy Antony created ZEPPELIN-2484: -- Summary: NullPointerException in addNewParagraphIfLastParagraphIsExecuted Key: ZEPPELIN-2484 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2484 Project: Zep

[GitHub] zeppelin issue #2299: [ZEPPELIN-2468] Enable websocket without Origin if all...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2299 Merge to master and branch-0.7 if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] zeppelin issue #2195: [ZEPPELIN-2319] new methods for ZeppelinContext

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2195 There can be simpler way to make a test for wrapper function using mockito. Other way is adding like [zRunTest](https://github.com/apache/zeppelin/blob/v0.7.1/zeppelin-server/src/test/j

[GitHub] zeppelin issue #2271: [ZEPPELIN-2414] Memory leak under scoped mode of Spark...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2271 #2262 has been merged. so now, could you try include commit only related to this contributions? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin pull request #2305: [ZEPPELIN-2382] Fixed windows compatibility of ...

2017-05-02 Thread cfries
GitHub user cfries reopened a pull request: https://github.com/apache/zeppelin/pull/2305 [ZEPPELIN-2382] Fixed windows compatibility of interpreter binding. ### What is this PR for? Fixing ZEPPELIN-2382: A fresh install of Zeppelin 0.7.1 failed to start on a Windows due

[GitHub] zeppelin pull request #2305: [ZEPPELIN-2382] Fixed windows compatibility of ...

2017-05-02 Thread cfries
Github user cfries closed the pull request at: https://github.com/apache/zeppelin/pull/2305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #2308: Some grammar updates.

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2308 Thanks @mressler for the contribution. Merge to master if no further comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2308: Some grammar updates.

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2308 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1210 @volumeint cool! Do you mind make a pullrequest with modification `test: /\.png(\?\S*)?$/, loader: 'url-loader'` ? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2017-05-02 Thread volumeint
Github user volumeint commented on the issue: https://github.com/apache/zeppelin/pull/1210 I just published a helium visualization that uses Leaflet. You can find it at (https://github.com/volumeint/helium-volume-leaflet). To get it working, I first had to patch [webpack.config.js]

[GitHub] zeppelin issue #2299: [ZEPPELIN-2468] Enable websocket without Origin if all...

2017-05-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2299 Thank you @elek for the fix. Tested on CentOS works well. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

2017-05-02 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2309 CI red -> AuthenticationIT.testGroupPermission --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] zeppelin pull request #2309: [ZEPPELIN-2482] added font size for paragraph

2017-05-02 Thread tinkoff-dwh
GitHub user tinkoff-dwh opened a pull request: https://github.com/apache/zeppelin/pull/2309 [ZEPPELIN-2482] added font size for paragraph ### What is this PR for? 1. Added possibilty to change font size of paragraph text 2. Fixed cloneParagraphAction (immediately after the cl

[jira] [Created] (ZEPPELIN-2483) Removing notebooks causes loss of changes in other notebooks

2017-05-02 Thread Nikita Uchitelev (JIRA)
Nikita Uchitelev created ZEPPELIN-2483: -- Summary: Removing notebooks causes loss of changes in other notebooks Key: ZEPPELIN-2483 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2483 Project:

[GitHub] zeppelin pull request #2308: Some grammar updates.

2017-05-02 Thread mressler
GitHub user mressler opened a pull request: https://github.com/apache/zeppelin/pull/2308 Some grammar updates. ### What is this PR for? Just noticed some grammar inconsistencies that I thought I could clean up while getting myself started on Zeppelin. Thanks for a great project!

[GitHub] zeppelin issue #2299: [ZEPPELIN-2468] Enable websocket without Origin if all...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2299 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2307: [HOTFIX]. Minor doc fix for back-end-angular.md

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2307 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2293: [ZEPPELIN-2461] Masking Jetty Server version with User...

2017-05-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2293 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2293: [ZEPPELIN-2461] Masking Jetty Server version with User...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2293 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2305: [ZEPPELIN-2382] Fixed windows compatibility of interpr...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2305 @cfries yes, close and re-open will trigger Jenkins and get latest travis job result. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2305: [ZEPPELIN-2382] Fixed windows compatibility of interpr...

2017-05-02 Thread cfries
Github user cfries commented on the issue: https://github.com/apache/zeppelin/pull/2305 (Sorry for the stupid question: what is the workaround if Jenkins fails but Travis succeeds on a re-run? Close and Re-Open? Could anyone just restart Jenkins?). --- If your project is set up for

[GitHub] zeppelin issue #2305: [ZEPPELIN-2382] Fixed windows compatibility of interpr...

2017-05-02 Thread cfries
Github user cfries commented on the issue: https://github.com/apache/zeppelin/pull/2305 The tests are not failing. See Travis: https://travis-ci.org/cfries/zeppelin/builds/227424005 (there is some issue with Jenkins/Travis which make tests sometimes fails). --- If your pr

[GitHub] zeppelin issue #2305: [ZEPPELIN-2382] Fixed windows compatibility of interpr...

2017-05-02 Thread rasgg
Github user rasgg commented on the issue: https://github.com/apache/zeppelin/pull/2305 I confirm this works. If the tests weren't failing i'd say LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] zeppelin issue #2293: [ZEPPELIN-2461] Masking Jetty Server version with User...

2017-05-02 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2293 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] zeppelin pull request #2307: [HOTFIX]. Minor doc fix for back-end-angular.md

2017-05-02 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/2307 [HOTFIX]. Minor doc fix for back-end-angular.md ### What is this PR for? The example in the doc would fail due to typo, straightforward fix. ### What type of PR is it? [Hot

[GitHub] zeppelin pull request #2307: [HOTFIX]. Minor doc fix for back-end-angular.md

2017-05-02 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/2307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Created] (ZEPPELIN-2482) Font size to paragraph config

2017-05-02 Thread Tinkoff DWH (JIRA)
Tinkoff DWH created ZEPPELIN-2482: - Summary: Font size to paragraph config Key: ZEPPELIN-2482 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2482 Project: Zeppelin Issue Type: New Featur

[GitHub] zeppelin issue #2306: [ZEPPELIN-2479] Fix incorrect tooltip view inside of v...

2017-05-02 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2306 @1ambda yeah that's better idea, I just pushed the changes and updated image --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin pull request #2307: [HOTFIX]. Minor doc fix for back-end-angular.md

2017-05-02 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2307 [HOTFIX]. Minor doc fix for back-end-angular.md ### What is this PR for? The example in the doc would fail due to typo, straightforward fix. ### What type of PR is it? [Hot F

[GitHub] zeppelin issue #2282: [ZEPPELIN-2447] Fix python interpreter as to use max r...

2017-05-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2282 @paularmand Selenium test is flaky, one thing left is unit test. Could you add unit test in `PythonInterpreterTest` ? --- If your project is set up for it, you can reply to this email and have y

[GitHub] zeppelin issue #2282: [ZEPPELIN-2447] Fix python interpreter as to use max r...

2017-05-02 Thread paularmand
Github user paularmand commented on the issue: https://github.com/apache/zeppelin/pull/2282 ping @zjffdu Do I have to look into it the Selenium test failure? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2293: [ZEPPELIN-2461] Masking Jetty Server version with User...

2017-05-02 Thread krishna-pandey
Github user krishna-pandey commented on the issue: https://github.com/apache/zeppelin/pull/2293 @prabhjyotsingh Jenkins job is successful. @Leemoonsoo, @felixcheung, @jongyoul Can you help review this? --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #2293: [ZEPPELIN-2461] Masking Jetty Server version wi...

2017-05-02 Thread krishna-pandey
Github user krishna-pandey closed the pull request at: https://github.com/apache/zeppelin/pull/2293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] zeppelin pull request #2293: [ZEPPELIN-2461] Masking Jetty Server version wi...

2017-05-02 Thread krishna-pandey
GitHub user krishna-pandey reopened a pull request: https://github.com/apache/zeppelin/pull/2293 [ZEPPELIN-2461] Masking Jetty Server version with User-configurable parameter ### What is this PR for? Security conscious organisations does not want to reveal the Application Serve

[GitHub] zeppelin issue #2306: [ZEPPELIN-2479] Fix incorrect tooltip view inside of v...

2017-05-02 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2306 Good! It would be nice to use `tooltip-class` with `tooltip-append-to-body` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-05-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung Have handled your review comments. Let me know if I missed any. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.