[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-20 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1775 For other reviewers - If you are using git 2.10+, Notebook revision feature will not work. Checkout [ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737) --- If your proje

[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.

2016-12-20 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1780 @bzz I agree with you and I will follow your word! Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 CI is all green now! Ready to review. Here are some brief summaries what I did. Since from this PR `anonymous`(non authenticated) user can't set note permission, related test cases

[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2016-12-20 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1787 @bikassaha zeppelin use spark repl api heavily. And spark repl is not stable as RDD/DataFrame api (It happens in spark 1.x), so it is possible to have changes in spark repl for spark feature relea

[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2016-12-20 Thread bikassaha
Github user bikassaha commented on the issue: https://github.com/apache/zeppelin/pull/1787 In a different jira, should we consider removing this check for 2.1, 2.2 since its unlikely that Spark will break common APIs in dot releases. Perhaps the policy can change to adding a check whe

[GitHub] zeppelin issue #1759: [ZEPPELIN-922] New interpreter registration mechanism ...

2016-12-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1759 As I posted the reason of CI failure in the above, it's not relevant. So will merge into master if there are no more comments. Thanks @DrIgor! --- If your project is set up for it, you can re

[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

2016-12-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1757 @lresende Thanks! Looks nice. BTW the [Build from Source](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#building-from-source) section went to too down side. How about put

[GitHub] zeppelin pull request #1749: [ZEPPELIN-1298] Address invalid ticket warnings...

2016-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1749 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...

2016-12-20 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1788 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2016-12-20 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1787 and btw, could you please test with the last 2.1 RC5 instead of snapshot builds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2016-12-20 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1787 Looks fine. Would you like to get this in before Spark 2.1 artifacts are in maven? I think we should reword the JIRA if that's the case - I don't think we should say we support 2.1 until w

[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...

2016-12-20 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1788 @Leemoonsoo @jongyoul @bzz Please help review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] zeppelin pull request #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkCluster...

2016-12-20 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1788 ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zRunTest ### What is this PR for? Fix the flaky test of ZeppelinSparkClusterTest.zRunTest. The issue is that z.run is not a blocking call so

[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

2016-12-20 Thread lresende
Github user lresende commented on the issue: https://github.com/apache/zeppelin/pull/1757 @AhyoungRyu @felixcheung Please take a look and let me know if I should update any other pieces. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2016-12-20 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1787 @Leemoonsoo @felixcheung Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] zeppelin pull request #1787: ZEPPELIN-1815. Support Spark 2.1

2016-12-20 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1787 ZEPPELIN-1815. Support Spark 2.1 ### What is this PR for? This PR is to update the max supported spark version to be 2.1 as Spark 2.1 is released. I didn't change pom file and travis scrip

[GitHub] zeppelin issue #1757: [ZEPPELIN-1074] Enhance SSL Support

2016-12-20 Thread lresende
Github user lresende commented on the issue: https://github.com/apache/zeppelin/pull/1757 No worries @AhyoungRyu I will make the suggested changes and add ZEPPELIN-1811 to this pr as well. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-20 Thread pmccaffrey6
Github user pmccaffrey6 commented on the issue: https://github.com/apache/zeppelin/pull/1776 Hey @bzz, Great catch! Sorry about that. I removed the unnecessary import. The error seems unrelated. It comes from: ``` 1470 21:03:56,259 ERROR org.apache.zeppelin.Abstra

[GitHub] zeppelin issue #1759: [ZEPPELIN-922] New interpreter registration mechanism ...

2016-12-20 Thread DrIgor
Github user DrIgor commented on the issue: https://github.com/apache/zeppelin/pull/1759 Ping-ping! :-) What should I do to complete pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-20 Thread rawkintrevo
Github user rawkintrevo commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin I think what @zjffdu and @bzz meant was that you could possibly call out this notebook in some where like [`docs/interpreter/flink.md`](https://github.com/apache/zeppelin/blo

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

2016-12-20 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1782 Those are other flaky tests already reported. You can search JIRA [here](https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZEPPELIN%20and%20text%20~%20%22testShowDescriptionOnInterpreterCre

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

2016-12-20 Thread DrIgor
Github user DrIgor commented on the issue: https://github.com/apache/zeppelin/pull/1782 @bzz @1ambda I attached CI logs Failures are: * `ZeppelinIT.testAngularDisplay:157->AbstractZeppelinIT.waitForText:84 » StaleElementReference` * `AngularElemTest:` `AngularEl

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-20 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 @bzz, I am not sure. We already have a *Word Count* example there to describe `Flink` usage. Where should we place the link to this example? --- If your project is set up for it, you can

[GitHub] zeppelin issue #1783: Zeppelin 727

2016-12-20 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1783 I agree with @AhyoungRyu. What she describes is the common way to link to paragraphs, so it seems reasonable to assume that is what users are used to. --- If your project is set up for it, you

[GitHub] zeppelin issue #1738: Strings should not be concatenated using '+' in a loop

2016-12-20 Thread bitchelov
Github user bitchelov commented on the issue: https://github.com/apache/zeppelin/pull/1738 @AhyoungRyu ok, ill update jira issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1738: Strings should not be concatenated using '+' in a loop

2016-12-20 Thread bitchelov
Github user bitchelov commented on the issue: https://github.com/apache/zeppelin/pull/1738 @Leemoonsoo https://issues.apache.org/jira/secure/ViewProfile.jspa?name=Sergey+Sokur --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

2016-12-20 Thread DrIgor
GitHub user DrIgor reopened a pull request: https://github.com/apache/zeppelin/pull/1782 [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure ### What is this PR for? Fix possible reason of DepInterpreterTest failure ### What type of PR is it? [Bug Fix]

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

2016-12-20 Thread DrIgor
Github user DrIgor closed the pull request at: https://github.com/apache/zeppelin/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin Right that would be better. So sorry about that ㅠ_ㅠ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-20 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 I am confused a bit :) @AhyoungRyu, do I need to drop my last commit or not? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

2016-12-20 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1716 Hello @bzz , could you please review? ci is green. I think ready for merge on this pr. Thank you :) Have a nice day. --- If your project is set up for it, you can reply t

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-20 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1775 good feature! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

2016-12-20 Thread DrIgor
Github user DrIgor closed the pull request at: https://github.com/apache/zeppelin/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

2016-12-20 Thread DrIgor
GitHub user DrIgor reopened a pull request: https://github.com/apache/zeppelin/pull/1782 [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure ### What is this PR for? Fix possible reason of DepInterpreterTest failure ### What type of PR is it? [Bug Fix]

[GitHub] zeppelin issue #1786: [ZEPPELIN-1842] sync on start when anonymous allowed

2016-12-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1786 this is ready for review, /cc @AhyoungRyu for help in review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #1786: [ZEPPELIN-1842] sync on start when anonymous al...

2016-12-20 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1786 [ZEPPELIN-1842] sync on start when anonymous allowed ### What is this PR for? this is to keep backward compatibility when it's possible to sync on start in anonymous mode.

[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2016-12-20 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2016-12-20 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1765 [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build ### What is this PR for? Add more logging as I could not reproduce it locally. ### What type of PR is

[jira] [Created] (ZEPPELIN-1842) Sync mechanism doesn't work on start if anonymous mode is on

2016-12-20 Thread Khalid Huseynov (JIRA)
Khalid Huseynov created ZEPPELIN-1842: - Summary: Sync mechanism doesn't work on start if anonymous mode is on Key: ZEPPELIN-1842 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1842 Project: Z

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

2016-12-20 Thread DrIgor
Github user DrIgor commented on the issue: https://github.com/apache/zeppelin/pull/1782 @1ambda yes, of course * https://travis-ci.org/apache/zeppelin/builds/185383249 * https://travis-ci.org/apache/zeppelin/builds/185389810 * https://travis-ci.org/apache/zeppelin/build

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

2016-12-20 Thread DrIgor
GitHub user DrIgor reopened a pull request: https://github.com/apache/zeppelin/pull/1782 [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure ### What is this PR for? Fix possible reason of DepInterpreterTest failure ### What type of PR is it? [Bug Fix]

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

2016-12-20 Thread DrIgor
Github user DrIgor closed the pull request at: https://github.com/apache/zeppelin/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

2016-12-20 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1782 Could you file CI links? :) also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2016-12-20 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1765 [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build ### What is this PR for? Add more logging as I could not reproduce it locally. ### What type of PR is

[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...

2016-12-20 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 Ping Ping ! Ci is green. It's time to ready to review this PR :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2016-12-20 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

2016-12-20 Thread DrIgor
Github user DrIgor closed the pull request at: https://github.com/apache/zeppelin/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

2016-12-20 Thread DrIgor
GitHub user DrIgor reopened a pull request: https://github.com/apache/zeppelin/pull/1782 [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure ### What is this PR for? Fix possible reason of DepInterpreterTest failure ### What type of PR is it? [Bug Fix]