[GitHub] zeppelin issue #1568: [ZEPPELIN-1590] Move shiro.ini to shiro.ini.template

2016-10-30 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1568 @anthonycorbacho It is already merged, but I think there are some places to be updated in docs. Do you mind to take care of them? --- If your project is set up for it, you can reply to this emai

[GitHub] zeppelin issue #1472: Add message of localhost:port on script

2016-10-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1472 @djKooks Sorry for my late response. Tested again and it works as expected only when I'm using wireless interpreter. If I connected wired internet, it doesn't print host info as be

[GitHub] zeppelin issue #1520: [ZEPPELIN-1061] Select default interpreter while creat...

2016-10-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1520 @kavinkumarks Tested and it works well as expected! Thanks again :) Merging this into master if there are no more discussions. --- If your project is set up for it, you can reply to this em

[GitHub] zeppelin pull request #1514: ZEPPELIN-1516. NPE LivySparkSQLInterpreter thro...

2016-10-30 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1557: ZEPPELIN-1577. LivyInterpreter should not use F...

2016-10-30 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1557 ZEPPELIN-1577. LivyInterpreter should not use FIFOScheduler ### What is this PR for? This PR create a new scheduler FIFOPerUserScheduler. So that each user's request is isolated. and it

[GitHub] zeppelin pull request #1557: ZEPPELIN-1577. LivyInterpreter should not use F...

2016-10-30 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1514: ZEPPELIN-1516. NPE LivySparkSQLInterpreter thro...

2016-10-30 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1514 ZEPPELIN-1516. NPE LivySparkSQLInterpreter thrown with %livy.sql interpreter ### What is this PR for? This PR fixed NPE issue in `LivySparkSQLIntepreter`, also it resolves the multiple

[GitHub] zeppelin issue #1549: ZEPPELIN-1547. Paragraph text should be trimmed

2016-10-30 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1549 Yes, the bug is due to interpreter parsing. But I think triming the paragraph text is the easiest fix. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1472: Add message of localhost:port on script

2016-10-30 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1472 @djKooks Hi, Is there any issue for installing `xmllint`? I found it in Mac and Linux but I'm not sure if it exists in all of linux and mac. Do you have any idea? --- If your project is set up

[GitHub] zeppelin issue #1513: ZEPPELIN-1472 - Create new LdapRealm based on Apache K...

2016-10-30 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1513 @nazgul33 I've heard your team used LDAP. Can you adopt and test this PR in your team? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] zeppelin issue #1513: ZEPPELIN-1472 - Create new LdapRealm based on Apache K...

2016-10-30 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1513 @gss2002 Hi, Thanks for the contribution. This PR actually has no problem itself or no breaking current behavior. So LGTM. But I'm just curious about the use case. Do you know the case to use thi

[GitHub] zeppelin issue #1570: [MINOR] High definition build status badge

2016-10-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1570 @tae-jun Since the failure reasons are not related with this change, you don't need to. Thanks for your contribution :) Merging this if there are no more discussions. --- If your

[GitHub] zeppelin issue #1559: [ZEPPELIN-1461] Doesn't display "description" value in...

2016-10-30 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1559 LGTM. Please rebase it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

2016-10-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1339 @jongyoul Thanks. Yeah i just wanted to get feedback about the change before updating the docs. @Leemoonsoo What do you think? --- If your project is set up for it, you can reply to this

[GitHub] zeppelin pull request #1568: [ZEPPELIN-1590] Move shiro.ini to shiro.ini.tem...

2016-10-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1568: [ZEPPELIN-1590] Move shiro.ini to shiro.ini.template

2016-10-30 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1568 LGTM. I'll merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

2016-10-30 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1339 @AhyoungRyu Basically, it's simple solution but you need to update docs. Except that, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1551: [ZEPPELIN-429] Replaced explicit types with diamonds

2016-10-30 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1551 Merging it there is no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] zeppelin pull request #1302: [ZEPPELIN-1306] Interpreter restarts on a note.

2016-10-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1302 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1570: [MINOR] High definition build status badge

2016-10-30 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1570 Thanks for comment @AhyoungRyu ! I guess CI is in a bad mood today 😄 Do I have to re-trigger CI? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] zeppelin issue #1570: [MINOR] High definition build status badge

2016-10-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1570 Nice! Thanks for taking care of this @tae-jun :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] zeppelin pull request #1570: [MINOR] High definition build status badge

2016-10-30 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1570 [MINOR] High definition build status badge ### What is this PR for? CI badge has low definition now. This change will use .svg image as badge (instead of .png!) before: ![image](

[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...

2016-10-30 Thread Peilin-Yang
Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug thanks, the error is really strange. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...

2016-10-30 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang still the same test failing but asking for different value this time... ``` Failed tests: SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSq

[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...

2016-10-30 Thread Peilin-Yang
Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug I've tested using `./grunt test` and it passed the test. But CI check still failed. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1566: [ZEPPELIN-1587] (WIP) Add impersonation routine in Spa...

2016-10-30 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1566 I don't know how much this helps in impersonation. At least it doesn't affect executor. Do you see any impact on the driver side ? --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1569: pom.xml change

2016-10-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1569 @hunylee Thanks for your contribution. Could you edit the PR description so that other ppl can understand what you intended easily? 😀 --- If your project is set up for it, you can reply to

[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...

2016-10-30 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1539 @astroshim there're errors during build: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project zeppelin-