ruby -c also complains about:
www/board/agenda/views/models/agenda.js.rb:184: void value expression
https://github.com/apache/whimsy/blob/master/www/board/agenda/views/models/agenda.js.rb#L184
On 29 March 2016 at 13:12, Sam Ruby wrote:
> On Tue, Mar 29, 2016 at 7:55 AM, sebb wrote:
>>
>> I thi
On Tue, Mar 29, 2016 at 7:55 AM, sebb wrote:
>
> I think there is a valid complaint: unexpected tRPAREN
>
> text = text.replace("^#{spaces}", 'g'), '')
>
> This is at:
>
> https://github.com/apache/whimsy/blob/master/www/test/icla/views/markdown.js.rb#L26
Fixed. Thanks!
- Sam Ruby
On 29 March 2016 at 11:04, Sam Ruby wrote:
> On Mon, Mar 28, 2016 at 3:16 PM, Sam Ruby wrote:
>> On Mon, Mar 28, 2016 at 3:10 PM, sebb wrote:
>>> Just noticed another syntax complaint:
>>>
>>> _label "Contributor's Name:", for: 'iclaname'
>>
>> Again, that's syntax that has been supported since
On Mon, Mar 28, 2016 at 3:16 PM, Sam Ruby wrote:
> On Mon, Mar 28, 2016 at 3:10 PM, sebb wrote:
>> Just noticed another syntax complaint:
>>
>> _label "Contributor's Name:", for: 'iclaname'
>
> Again, that's syntax that has been supported since Ruby 1.9.
>
>> The colon after for is flagged as une
On Mon, Mar 28, 2016 at 3:10 PM, sebb wrote:
> Just noticed another syntax complaint:
>
> _label "Contributor's Name:", for: 'iclaname'
Again, that's syntax that has been supported since Ruby 1.9.
> The colon after for is flagged as unexpected.
>
> The other main complaint is about:
>
> onClick:
Just noticed another syntax complaint:
_label "Contributor's Name:", for: 'iclaname'
The colon after for is flagged as unexpected.
The other main complaint is about:
onClick: -> {@form = ICLA}
On 28 March 2016 at 19:54, sebb wrote:
> On 28 March 2016 at 19:47, Sam Ruby wrote:
>> On Mon, Ma
On Mon, Mar 28, 2016 at 2:54 PM, sebb wrote:
> On 28 March 2016 at 19:47, Sam Ruby wrote:
>> On Mon, Mar 28, 2016 at 2:06 PM, sebb wrote:
>>> The class: attribute is frequently used in Wunderbar HTML tags.
>>
>> Indeed.
>>
>>> This causes problems for Ruby syntax checkers.
>>
>> I'd be curious a
On 28 March 2016 at 19:47, Sam Ruby wrote:
> On Mon, Mar 28, 2016 at 2:06 PM, sebb wrote:
>> The class: attribute is frequently used in Wunderbar HTML tags.
>
> Indeed.
>
>> This causes problems for Ruby syntax checkers.
>
> I'd be curious as to which ones, as that would indicate a syntax
> check
On Mon, Mar 28, 2016 at 2:06 PM, sebb wrote:
> The class: attribute is frequently used in Wunderbar HTML tags.
Indeed.
> This causes problems for Ruby syntax checkers.
I'd be curious as to which ones, as that would indicate a syntax
checker that hasn't been updated since Ruby 1.9 was release in
