Re: [whimsy] branch master updated: Simplify; drop unused vars

2020-01-13 Thread sebb
On Mon, 13 Jan 2020 at 01:55, Sam Ruby wrote: > On Sun, Jan 12, 2020 at 5:37 PM sebb wrote: > > > > Oops - this was a complaint from ruby --debug, obviously a false positive > > It turns out that it was not a false positive. Without the 'self.', > it WAS being treated like a local variable. > >

Re: [whimsy] branch master updated: Simplify; drop unused vars

2020-01-12 Thread Sam Ruby
On Sun, Jan 12, 2020 at 5:37 PM sebb wrote: > > Oops - this was a complaint from ruby --debug, obviously a false positive It turns out that it was not a false positive. Without the 'self.', it WAS being treated like a local variable. Good catch! - Sam Ruby > On Sun, 12 Jan 2020 at 22:28, Sam

Re: [whimsy] branch master updated: Simplify; drop unused vars

2020-01-12 Thread Sam Ruby
On Sun, Jan 12, 2020 at 5:37 PM sebb wrote: > > Oops - this was a complaint from ruby --debug, obviously a false positive Would self.members = eliminate the warning? - Sam Ruby > On Sun, 12 Jan 2020 at 22:28, Sam Ruby wrote: > > > Um, members is not an unused variable. See: > > > > https://g

Re: [whimsy] branch master updated: Simplify; drop unused vars

2020-01-12 Thread sebb
Oops - this was a complaint from ruby --debug, obviously a false positive On Sun, 12 Jan 2020 at 22:28, Sam Ruby wrote: > Um, members is not an unused variable. See: > > https://github.com/apache/whimsy/blob/master/lib/whimsy/asf/ldap.rb#L1020 > > - Sam Ruby > > On Sun, Jan 12, 2020 at 5:22 PM

Re: [whimsy] branch master updated: Simplify; drop unused vars

2020-01-12 Thread Sam Ruby
Um, members is not an unused variable. See: https://github.com/apache/whimsy/blob/master/lib/whimsy/asf/ldap.rb#L1020 - Sam Ruby On Sun, Jan 12, 2020 at 5:22 PM wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a commit to branch master > in reposit