Re: Tiny bug in secretary workbench

On Tue, 24 Sept 2024 at 21:53, Craig Russell wrote: > > I just filed an ICLA that had an attachment named Committer-icla-pdf.asc There are no .asc files ending in -icla.pdf.asc in the 202409.yml file, so I don't see how this can be investigated > The workbench properly renamed and filed the sig

Tiny bug in secretary workbench

I just filed an ICLA that had an attachment named Committer-icla-pdf.asc The workbench properly renamed and filed the sig as icla.pdf.asc along with the icla.pdf. But it did not properly remove the sig file from the email message. I had to do this manually. Craig Craig L Russell c...@apache.o

Re: Bug in secretary workbench with multiple documents

FTR: this should now be working On Fri, 9 Aug 2024 at 17:46, Craig Russell wrote: > > Hi, > > When there are multiple documents in an email, the recent process was to file > each document in turn, and when no documents are left to file, return to the > main page. > > But the recent change to im

Bug in secretary workbench with multiple documents

Hi, When there are multiple documents in an email, the recent process was to file each document in turn, and when no documents are left to file, return to the main page. But the recent change to immediately go to the main page after filing one document results in a bug when there are multiple

Re: Bug in secretary workbench

OK, so it looks like Whimsy is behaving OK; the problem is with the browser(s). On Tue, 28 May 2024 at 12:20, Craig Russell wrote: > > I should have mentioned that I deleted the blank form in workbench. > > On Tue, May 28, 2024, 12:07 sebb wrote: > > > On Tue, 28 May 2024 at 06:54, Craig Russell

Re: Bug in secretary workbench

I should have mentioned that I deleted the blank form in workbench. On Tue, May 28, 2024, 12:07 sebb wrote: > On Tue, 28 May 2024 at 06:54, Craig Russell wrote: > > > > The ICLA to be filed from London seems to display the first page of the > pdf but then scrolling, the entire page hangs. In or

Re: Bug in secretary workbench

On Tue, 28 May 2024 at 06:54, Craig Russell wrote: > > The ICLA to be filed from London seems to display the first page of the pdf > but then scrolling, the entire page hangs. In order to continue, the page > needs to be force reloaded. > > The ICLA opens just fine in Preview pdf viewer. > > Can

Bug in secretary workbench

The ICLA to be filed from London seems to display the first page of the pdf but then scrolling, the entire page hangs. In order to continue, the page needs to be force reloaded. The ICLA opens just fine in Preview pdf viewer. Can someone open the ICLA in the workbench and see if you can scroll

Re: Bug in secretary workbench

It is the browser that displays the PDF, so there's not a lot that the Whimsy code can do. Works fine for me in Opera, Firefox, Chrome. Only hangs in Safari. Sebb On Sun, 5 Nov 2023 at 01:46, Craig Russell wrote: > > The ICLA submitted today from J.S. fails. When viewing the pdf, scrolling > s

Bug in secretary workbench

The ICLA submitted today from J.S. fails. When viewing the pdf, scrolling stops in the middle of the document and the page hangs. The only thing that it will do is reload the page and then try again. Seems that scrolling the pdf causes a failure. Craig L Russell c...@apache.org

Re: Bug in secretary workbench

Hi Sebb, Your patch seems to have fixed the problem. The only remaining question for me is whether the validity of the @from variable should be in any other document processing tasks (ccla, grant, emeritus). Thanks, Craig > On Feb 11, 2021, at 4:44 AM, sebb wrote: > > On Thu, 11 Feb 2021 at

Re: Bug in secretary workbench

On Thu, 11 Feb 2021 at 02:10, Craig Russell wrote: > > I have to say that mail clients do mess up email addresses, so I'll double > check this one. > > The error message would indicate that the @from variable is actually empty: > > Warning: Invalid From address '' > > > The actual @from email add

Re: Bug in secretary workbench

I have to say that mail clients do mess up email addresses, so I'll double check this one. The error message would indicate that the @from variable is actually empty: Warning: Invalid From address '' The actual @from email address in the message-to-be-sent is: Craig L Russell I dunno where

Re: Bug in secretary workbench

The error message suggests that the @from variable is empty, so no wonder the RE fails. On Wed, 10 Feb 2021 at 18:08, Roy T. Fielding wrote: > > Wow, Apple Mail really messed that up by adding mailto links everywhere. What > I meant was > > you should also note that \w excludes hyphen and ".

Re: Bug in secretary workbench

Wow, Apple Mail really messed that up by adding mailto links everywhere. What I meant was you should also note that \w excludes hyphen and ".", so apache@apache.org will not match regardless. You need [\w\+\=\.\-]+@apache.org (or something), or just check the end with /\@apache\

Re: Bug in secretary workbench

Just a guess, but the =~ operator in Ruby returns either the index inside the string where the match is found or nil, depending on the context. You might want to try _warn "Invalid From address #{@from}" if @from !~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/ but you should also note that \w excl

Re: Bug in secretary workbench

Current error message says: Warning: Invalid From address '' On Wed, 10 Feb 2021 at 05:53, sebb wrote: > > On Wed, 10 Feb 2021 at 00:41, Craig Russell wrote: > > > > I think this is the change that made the error occur. > > > > https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002a

Re: Bug in secretary workbench

On Wed, 10 Feb 2021 at 00:41, Craig Russell wrote: > > I think this is the change that made the error occur. > > https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5 > >

Re: Bug in secretary workbench

This is why the *exact* error message is needed to debug the code. On Wed, 10 Feb 2021 at 01:35, Matt Sicker wrote: > > That looks like the same regex code, so I'm not sure what's going on. > > On Tue, 9 Feb 2021 at 18:41, Craig Russell wrote: > > > > I think this is the change that made the err

Re: Bug in secretary workbench

That looks like the same regex code, so I'm not sure what's going on. On Tue, 9 Feb 2021 at 18:41, Craig Russell wrote: > > I think this is the change that made the error occur. > > https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05

Re: Bug in secretary workbench

I think this is the change that made the error occur. https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5

Re: Bug in secretary workbench

I’ve been getting the same error message. On Mon, Feb 8, 2021 at 17:51 sebb wrote: > A quick search in GitHub gives the following: > > https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22 > > > https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/sec

Re: Bug in secretary workbench

A quick search in GitHub gives the following: https://github.com/apache/whimsy/search?q=%22Invalid+From+address%22 https://github.com/apache/whimsy/blob/5d0e0d05156fb011bb679c95b9f76fe35b7ffab6/www/secretary/workbench/views/actions/icla.json.rb#L13 At a quick glance RE looks OK. And AFAIK, no-on

Bug in secretary workbench

Whenever I file a document, I get the error message: Warning: Invalid From address Continue anyway? But there is nothing wrong with the address, and everything completes normally, and at the end, another warning with a red (return to mail index) The headers look fine and the mail is processed

Re: Bug in secretary workbench -- additional ICLA when the first ICLA was signed with gpg

I think it's working now. [The code could be neater...] On Wed, 30 Dec 2020 at 16:43, sebb wrote: > > Sorry to say it does not work on the live system. > I think it is a credentials issue which did not appear in local testing. > > I'll try and fix it shortly. > > On Wed, 30 Dec 2020 at 15:35, seb

Re: Bug in secretary workbench -- additional ICLA when the first ICLA was signed with gpg

Sorry to say it does not work on the live system. I think it is a credentials issue which did not appear in local testing. I'll try and fix it shortly. On Wed, 30 Dec 2020 at 15:35, sebb wrote: > > The latest commit [1] should fix this > > The iclas.txt listing should now be updated as part of t

Re: Bug in secretary workbench -- additional ICLA when the first ICLA was signed with gpg

The latest commit [1] should fix this The iclas.txt listing should now be updated as part of the secretary workbench processing. Let me know if there are any issues [1] https://github.com/apache/whimsy/commit/61e6e7974ee3bcb964cb6477912b4ab29e21ab5f On Mon, 28 Dec 2020 at 18:11, Sam Ruby w

Re: Bug in secretary workbench -- additional ICLA when the first ICLA was signed with gpg

Perhaps whimsysvn should be given read access after all? At least temporarily until another approach can be implemented? https://lists.apache.org/thread.html/r5bfcd501e21a70ec7c6bebbf91995ef06c2a7e347afa9dbaed040b97%40%3Cprivacy.apache.org%3E - Sam Ruby On Mon, Dec 28, 2020 at 12:00 PM sebb wr

Re: Bug in secretary workbench -- additional ICLA when the first ICLA was signed with gpg

Here is the error from the update job: https://whimsy.apache.org/status/#svn-iclas On Mon, 28 Dec 2020 at 14:49, Craig Russell wrote: > > > > > On Dec 28, 2020, at 5:05 AM, sebb wrote: > > > > I think that is because the job that updates the cached list of icla > > file names no longer has acces

Re: Bug in secretary workbench -- additional ICLA when the first ICLA was signed with gpg

> On Dec 28, 2020, at 5:05 AM, sebb wrote: > > I think that is because the job that updates the cached list of icla > file names no longer has access to the SVN directory to be able to > list the file names. The error occurs after reading the existing ICLA names and details (from iclas.txt a

Re: Bug in secretary workbench -- additional ICLA when the first ICLA was signed with gpg

I think that is because the job that updates the cached list of icla file names no longer has access to the SVN directory to be able to list the file names. It might be possible to do away with the cache, and fetch the names on demand. On Mon, 28 Dec 2020 at 04:41, Craig Russell wrote: > > This s

Bug in secretary workbench -- additional ICLA when the first ICLA was signed with gpg

This second ICLA for Kent Yao is still pending in the workbench. The second ICLA cannot be filed due to: # /x1/srv/whimsy/www/secretary/workbench/views/actions/icla2.json.rb:36:in `_evaluate' /x1/srv/whimsy/www/secretary/workbench/server.rb:121:in `block in ' /x1/srv/whimsy/lib/whimsy/asf/rack.r

Re: Bug in secretary workbench: additional ICLA?

On Thu, Jan 2, 2020 at 10:23 AM Sam Ruby wrote: > > On Wed, Jan 1, 2020 at 8:04 PM Craig Russell wrote: > > > > When filing the additional ICLA for Doug Service (currently pending), the > > preview says it will move the current ICLA to /icla.pdf and then file > > the additional ICLA under the n

Re: Bug in secretary workbench: additional ICLA?

On Wed, Jan 1, 2020 at 8:04 PM Craig Russell wrote: > > When filing the additional ICLA for Doug Service (currently pending), the > preview says it will move the current ICLA to /icla.pdf and then file > the additional ICLA under the name iclaN.pdf. This should be icla2.pdf. > > So either the pr

Bug in secretary workbench: additional ICLA?

When filing the additional ICLA for Doug Service (currently pending), the preview says it will move the current ICLA to /icla.pdf and then file the additional ICLA under the name iclaN.pdf. This should be icla2.pdf. So either the preview is wrong or the new file name is wrong, but I cannot tell

Re: Bug in secretary workbench -- tainted from_addr

Seems to work. Craig > On Nov 6, 2018, at 2:52 AM, Sam Ruby wrote: > > I don't know what changed, and I'm traveling at the moment, but I > added a call to untaint. > > - Sam Ruby > On Mon, Nov 5, 2018 at 3:40 PM Craig Russell > wrote: >> >> Can we please take an

Re: Bug in secretary workbench -- tainted from_addr

I don't know what changed, and I'm traveling at the moment, but I added a call to untaint. - Sam Ruby On Mon, Nov 5, 2018 at 3:40 PM Craig Russell wrote: > > Can we please take another look at this issue? I'm afraid it might start to > affect account creation since no email with the vote result

Re: Bug in secretary workbench -- tainted from_addr

Can we please take another look at this issue? I'm afraid it might start to affect account creation since no email with the vote result is being sent to root. Thanks, Craig > On Oct 30, 2018, at 8:00 PM, Sam Ruby wrote: > > On Tue, Oct 30, 2018 at 10:43 PM Sam Ruby wrote: >> >> It would be

Re: Bug in secretary workbench -- tainted from_addr

> On Oct 30, 2018, at 7:43 PM, Sam Ruby wrote: > > On Tue, Oct 30, 2018 at 1:54 PM Craig Russell wrote: >> >> This now happens on every request for a new account. I don't even see where >> the "from_addr" is set. > > I wonder what has changed. > >> Is the bug that the from_addr is never se

Re: Bug in secretary workbench -- tainted from_addr

On Tue, Oct 30, 2018 at 10:43 PM Sam Ruby wrote: > > It would be safe to do something like the following, however: > > @from.untaint if @from =~ /\A\w+@apache\.org\z/ Looks like it may be worth adding or @from =~ /\A"?[\s\w]+"?\s+<\w+@apache\.org>\z/ > - Sam Ruby

Re: Bug in secretary workbench -- tainted from_addr

On Tue, Oct 30, 2018 at 1:54 PM Craig Russell wrote: > > This now happens on every request for a new account. I don't even see where > the "from_addr" is set. I wonder what has changed. > Is the bug that the from_addr is never set? Or is that done in Mail.new? Looks to me that it is in a diffe

Re: Bug in secretary workbench -- tainted from_addr

On Tue, 30 Oct 2018 at 19:27, Craig Russell wrote: > > # build mail from template > mail = message.reply( > subject: "ICLA for #{@pubname}", > from: @from, > to: "#{@pubname.inspect} <#{@email}>", > cc: [ > ('secret...@apache.org' unless use_Bcc), > ("private@#{@pmc.m

Re: Bug in secretary workbench -- tainted from_addr

# build mail from template mail = message.reply( subject: "ICLA for #{@pubname}", from: @from, to: "#{@pubname.inspect} <#{@email}>", cc: [ ('secret...@apache.org' unless use_Bcc), ("private@#{@pmc.mail_list}.apache.org" if @pmc), # copy pmc (@podling.private_mai

Re: Bug in secretary workbench -- tainted from_addr

On Tue, 30 Oct 2018 at 17:54, Craig Russell wrote: > > This now happens on every request for a new account. I don't even see where > the "from_addr" is set. I think it's done in the template processing, i.e. here: mail = Mail.new(template('acreq.erb')) But when I had a look I could not work ou

Bug in secretary workbench -- tainted from_addr

This now happens on every request for a new account. I don't even see where the "from_addr" is set. Is the bug that the from_addr is never set? Or is that done in Mail.new? ## # email root@

trivial bug in secretary workbench second icla

If the second icla is for a non-committer, the non-committer gets an email sent to notinav...@apache.org. Fwd: failure notice > Begin forwarded message: > > From: mailer-dae...@apache.org > Subject: failure notice > Date: March 2, 2018 at 11:43:39 AM PST > To: secret...@apache.org > > Hi. Thi

Re: Bug in secretary workbench

On Thu, Nov 16, 2017 at 2:48 PM, Craig Russell wrote: > The icla message now appears but I'll leave it unprocessed for now until > someone can figure out why it is flaky. Fixed. Reproduced and fixed. The problem was with the latest email; new emails would move the problem. And often the new e

Re: Bug in secretary workbench

The icla message now appears but I'll leave it unprocessed for now until someone can figure out why it is flaky. Craig > On Nov 16, 2017, at 11:29 AM, Craig Russell wrote: > > There is a new icla from Awasum to be processed for the fineract project but > it cannot be accessed. > > The icla s

Bug in secretary workbench

There is a new icla from Awasum to be processed for the fineract project but it cannot be accessed. The icla shows up briefly in the main page but immediately is erased so it cannot be processed. I have seen this behavior in other cases where the subject is identical to another message. I ju