[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

2021-07-26 Thread GitBox
clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887156529 This is great. Can you push it to the branch? I'd love to understand how you test this. Is there some test case infrastructure where we can add test cases? -- This is a

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

2021-07-26 Thread GitBox
sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887082137 I have created a DRAFT method to split cn into sn and givenName: ASF::Person.ldap_parse_cn_DRAFT. However, AFAICT there is currently no way to actually use sn and givenName.

Draft method to convert cn to sn + givenName

2021-07-26 Thread sebb
I have added a draft implementation of a method to convert cn (i.e. Public name) to sn and givenName. [1] Processing is currently very simplistic, but it should be sufficient to allow LDAP entries to be created, regardless of how many words are present in the Public name. Note that givenName is r

Re: [whimsy] branch family-first updated: Fix obvious errors

2021-07-26 Thread Sam Ruby
On Sun, Jul 25, 2021 at 7:40 PM Craig Russell wrote: > > > On Jul 25, 2021, at 2:06 PM, sebb wrote: > > > > AFAICT the code cannot have been tested -- previously it did not even > > compile, and there was a missing method. > > You are completely correct. I made the decision not to invest the few