Re: Bug in secretary workbench

2021-02-10 Thread Craig Russell
I have to say that mail clients do mess up email addresses, so I'll double check this one. The error message would indicate that the @from variable is actually empty: Warning: Invalid From address '' The actual @from email address in the message-to-be-sent is: Craig L Russell I dunno where

Re: Bug in secretary workbench

2021-02-10 Thread sebb
The error message suggests that the @from variable is empty, so no wonder the RE fails. On Wed, 10 Feb 2021 at 18:08, Roy T. Fielding wrote: > > Wow, Apple Mail really messed that up by adding mailto links everywhere. What > I meant was > > you should also note that \w excludes hyphen and ".

Re: Bug in secretary workbench

2021-02-10 Thread Roy T. Fielding
Wow, Apple Mail really messed that up by adding mailto links everywhere. What I meant was you should also note that \w excludes hyphen and ".", so apache@apache.org will not match regardless. You need [\w\+\=\.\-]+@apache.org (or something), or just check the end with /\@apache\

Re: Bug in secretary workbench

2021-02-10 Thread Roy T. Fielding
Just a guess, but the =~ operator in Ruby returns either the index inside the string where the match is found or nil, depending on the context. You might want to try _warn "Invalid From address #{@from}" if @from !~ /\A("?[\s\w]+"?\s+<)?\w+@apache\.org>?\z/ but you should also note that \w excl

Re: Bug in secretary workbench

2021-02-10 Thread Matt Sicker
Current error message says: Warning: Invalid From address '' On Wed, 10 Feb 2021 at 05:53, sebb wrote: > > On Wed, 10 Feb 2021 at 00:41, Craig Russell wrote: > > > > I think this is the change that made the error occur. > > > > https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002a

Re: Bug in secretary workbench

2021-02-10 Thread sebb
On Wed, 10 Feb 2021 at 00:41, Craig Russell wrote: > > I think this is the change that made the error occur. > > https://github.com/apache/whimsy/commit/32076c779bbc990f7e8ea0b002ac62903cd4fb1a#diff-7acc05691a456b71d17e29ce33d05a2cf43783be9d87eb7fac49458a46b47ab5 > >

Re: Bug in secretary workbench

2021-02-10 Thread sebb
This is why the *exact* error message is needed to debug the code. On Wed, 10 Feb 2021 at 01:35, Matt Sicker wrote: > > That looks like the same regex code, so I'm not sure what's going on. > > On Tue, 9 Feb 2021 at 18:41, Craig Russell wrote: > > > > I think this is the change that made the err