Re: Error: Cannot find module 'jsdom-global/register'

2020-06-11 Thread sebb
On Thu, 11 Jun 2020 at 22:17, Sam Ruby wrote: > > On Thu, Jun 11, 2020 at 5:08 PM sebb wrote: > > > > On Thu, 11 Jun 2020 at 21:53, Sam Ruby wrote: > > > > > > On Thu, Jun 11, 2020 at 4:46 PM sebb wrote: > > > > > > > > On Thu, 11 Jun 2020 at 19:36, Sam Ruby wrote: > > > > > > > > > > On Thu,

Re: Error: Cannot find module 'jsdom-global/register'

2020-06-11 Thread Sam Ruby
On Thu, Jun 11, 2020 at 5:08 PM sebb wrote: > > On Thu, 11 Jun 2020 at 21:53, Sam Ruby wrote: > > > > On Thu, Jun 11, 2020 at 4:46 PM sebb wrote: > > > > > > On Thu, 11 Jun 2020 at 19:36, Sam Ruby wrote: > > > > > > > > On Thu, Jun 11, 2020 at 2:19 PM sebb wrote: > > > > > > > > > > I get the

Re: Error: Cannot find module 'jsdom-global/register'

2020-06-11 Thread sebb
On Thu, 11 Jun 2020 at 21:53, Sam Ruby wrote: > > On Thu, Jun 11, 2020 at 4:46 PM sebb wrote: > > > > On Thu, 11 Jun 2020 at 19:36, Sam Ruby wrote: > > > > > > On Thu, Jun 11, 2020 at 2:19 PM sebb wrote: > > > > > > > > I get the following error when running the tests locally: > > > > > > > > $

Re: Error: Cannot find module 'jsdom-global/register'

2020-06-11 Thread Sam Ruby
On Thu, Jun 11, 2020 at 4:46 PM sebb wrote: > > On Thu, 11 Jun 2020 at 19:36, Sam Ruby wrote: > > > > On Thu, Jun 11, 2020 at 2:19 PM sebb wrote: > > > > > > I get the following error when running the tests locally: > > > > > > $ rspec www/board/agenda/ > > > Error: Cannot find module 'jsdom-glo

Re: Error: Cannot find module 'jsdom-global/register'

2020-06-11 Thread sebb
On Thu, 11 Jun 2020 at 19:36, Sam Ruby wrote: > > On Thu, Jun 11, 2020 at 2:19 PM sebb wrote: > > > > I get the following error when running the tests locally: > > > > $ rspec www/board/agenda/ > > Error: Cannot find module 'jsdom-global/register' > > What happens if you run the following instead

Re: Error: Cannot find module 'jsdom-global/register'

2020-06-11 Thread Sam Ruby
On Thu, Jun 11, 2020 at 2:19 PM sebb wrote: > > I get the following error when running the tests locally: > > $ rspec www/board/agenda/ > Error: Cannot find module 'jsdom-global/register' What happens if you run the following instead? $ bundle exec rake test This shouldn't be necessary, but sho

Error: Cannot find module 'jsdom-global/register'

2020-06-11 Thread sebb
I get the following error when running the tests locally: $ rspec www/board/agenda/ Error: Cannot find module 'jsdom-global/register' The tests work OK in Travis, so I assume there must be something missing from my installation, but I don't know what. It would be useful to fix this so I can chec

Re: Board agenda broken, "ensure" keyword error

2020-06-11 Thread sebb
Sorry, my bad -- fixed (I hope) On Thu, 11 Jun 2020 at 17:07, Bertrand Delacretaz wrote: > > On Thu, Jun 11, 2020 at 6:01 PM Roy T. Fielding wrote: > > If you have write access, please commit that change. I realized the same > > just a few minutes ago. It doesn't matter if you break something be

Re: Board agenda broken, "ensure" keyword error

2020-06-11 Thread Bertrand Delacretaz
On Thu, Jun 11, 2020 at 6:01 PM Roy T. Fielding wrote: > If you have write access, please commit that change. I realized the same > just a few minutes ago. It doesn't matter if you break something because > the tool is broken already... Good point - I don't have write access however. Created htt

Re: Board agenda broken, "ensure" keyword error

2020-06-11 Thread Roy T. Fielding
> On Jun 11, 2020, at 8:39 AM, Bertrand Delacretaz > wrote: > > Hi, > > https://whimsy.apache.org/board/agenda/ displays this error message: > > /x1/srv/whimsy/www/board/agenda/models/agenda.rb:216: syntax error, > unexpected keyword_ensure, expecting keyword_end > ensure > > I see there w

Board agenda broken, "ensure" keyword error

2020-06-11 Thread Bertrand Delacretaz
Hi, https://whimsy.apache.org/board/agenda/ displays this error message: /x1/srv/whimsy/www/board/agenda/models/agenda.rb:216: syntax error, unexpected keyword_ensure, expecting keyword_end ensure I see there was a commit in the last hour, I'm no Whimsy nor Ruby expert but it looks like an "en