Yes, the goal is to migrate noderef/node to be subclass of object/objectref.
The migration needs to take a few steps to complete
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#issuecomm
I have one question about `_type_child_slots`. If the child class is a base
class for others and also defines `_type_child_slots`, will you check if it
overflows its parent `_type_child_slots`?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
Re overflow, the child that has class slots will count as number of slots
rather than a single class, as in the RFC code.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/issues/4116#issuecomment-
ping @zhiics for another round of review
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#issuecomment-542026749
We had a meeting with @Hzfengsy today. We discussed the difference and
similarity of our solutions. They are different in the front-end: our solution
tries to make it as transparent as possible to make it easy-using while #4095
provides more controllability to the user (schedule developer). They
Merged #4115 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#event-2712622451
@tqchen thanks. This is now merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#issuecomment-542047511
