[dmlc/tvm] [RFC][Frontend] Return module for Relay frontend converter (#3346)

2019-06-11 Thread Haichen Shen
As we have pass manager in Relay optimization and mostly use module as optimization unit, I suggest we change the Relay frontend converter to return a module instead of a function. The change also makes easier add prelude and global var in the frontend converter in the future. Frontend converter

Re: [dmlc/tvm] [RFC][Frontend] Return module for Relay frontend converter (#3346)

2019-06-11 Thread Zhi
Yeah, this is exactly what I think as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/issues/3346#issuecomment-501072122

Re: [dmlc/tvm] [RFC][Frontend] Return module for Relay frontend converter (#3346)

2019-06-11 Thread Wei Chen
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/issues/3346#issuecomment-501077110

Re: [dmlc/tvm] [RFC][Frontend] Return module for Relay frontend converter (#3346)

2019-06-11 Thread Yong Wu
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/issues/3346#issuecomment-501089807