Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)

2019-10-14 Thread Zhi
Merged #4115 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/pull/4115#event-2712622451

Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)

2019-10-14 Thread Zhi
@tqchen thanks. This is now merged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/pull/4115#issuecomment-542047511

Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)

2019-10-14 Thread Tianqi Chen
ping @zhiics for another round of review -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/pull/4115#issuecomment-542026749

Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)

2019-10-14 Thread Tianqi Chen
Yes, the goal is to migrate noderef/node to be subclass of object/objectref. The migration needs to take a few steps to complete -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/pull/4115#issuecomm

Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)

2019-10-13 Thread Tianqi Chen
@junrushao1994 @icemelon9 @yzh119 can you help review this PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/pull/4115#issuecomment-541470010

Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)

2019-10-12 Thread Tianqi Chen
cc @jroesch @icemelon9 @junrushao1994 @zhiics -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/pull/4115#issuecomment-541387894

[dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)

2019-10-12 Thread Tianqi Chen
This PR introduces a new object protocol to unify the node and object. We also updated the existing runtime::vm code to make use of the new system. Update to the node will be done in a follow-up PR. Other changes: - Remove object-related code in json serializer as that code logic was not comple