Thanks guys for the discussion! The RFC is merged :-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/36#issuecomment-930344604
Merged #36 into main.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/36#event-5382108357
Thanks guys for the discussion! If the comments and concerns are all addressed,
let's move on and merge this PR after 24h
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/36#issuecommen
Great discussions. If we are encouraging a common idiom(e.g. use T for tir).
We might actually want to encourage print in T as prefix to be consistent on
what users might write(and further edit with auto-completion), assuming we
always encourage user write `from tvm.script import tir as T`. As l
Thanks, @altanh. Your suggestion makes sense to me. To be specific, here are
two cases: parse from a python script and string.
1. When we parse from a python script, we detect the prefix `T` from the python
env (through function `__globals__`, i.e. you can even use `XXX.block` if with
`from tvm.
I support this change. One suggestion is that we keep a canonical namespace
that will always be parsed correctly to the TIR namespace (e.g. `tir.block`
will always work), and in particular use this identifier during printing.
Mentioning this here since I noticed the PR apache/tvm#9115 is printin
It's a rfc for changing TVMScript namespace to enable auto-completion
support and pass pylint checks
@tqchen @junrushao1994 @tkonolige
You can view, comment on, or merge this pull request online at:
https://github.com/apache/tvm-rfcs/pull/36
-- Commit Summary --
* https://github.com/apach
