[TVM Discuss] [Development] *Attrs not inheriting from Attrs

2020-06-19 Thread tqchen via TVM Discuss
I agree, we could shoot an error in the strict mode to forbid pure object construction --- [Visit Topic](https://discuss.tvm.ai/t/attrs-not-inheriting-from-attrs/7029/4) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click he

[TVM Discuss] [Development] *Attrs not inheriting from Attrs

2020-06-19 Thread Thomas V via TVM Discuss
Thank you. I filed [PR 5853](https://github.com/apache/incubator-tvm/pull/5853). To put in some long term perspective: I wonder whether one could somehow systematically see if things of class Object rather than a subclass are instantiated and not allow that. Best regards Thomas --- [Vis

[TVM Discuss] [Development] *Attrs not inheriting from Attrs

2020-06-18 Thread tqchen via TVM Discuss
I agree that it is good to add those attrs to the python side so that they maps to Attrs --- [Visit Topic](https://discuss.tvm.ai/t/attrs-not-inheriting-from-attrs/7029/2) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click

[TVM Discuss] [Development] *Attrs not inheriting from Attrs

2020-06-18 Thread Thomas V via TVM Discuss
I noticed that while most Attrs inherit from Attrs, some don't and are only on the C++ side (thus being mapped to Object). In particular, they don't have the `keys` function. Now defining them with a short docstring like the others is easy, but is that an OK patch? Best regards Thomas The o