GitHub user robguima opened a pull request:
https://github.com/apache/trafficserver/pull/455
TS-4176: s3_auth add support for matrix params
@shukitchan please review
https://issues.apache.org/jira/browse/TS-4176
You can merge this pull request into a Git repository by
Github user robguima commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-180640259
@shukitchan just to undo my formatting change from older patch - think
someone did that between 5.3 and 6.x
---
If your project is set up for it, you can reply
Github user robguima commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-180702368
@zwoop done thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user robguima commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-180907419
Yes, we can be fairly sure it doesn't (break anything), because:
a) we've added functionality not changing the way it worked before (bug
asid
Github user robguima commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-181591169
@zwoop I will squash it to one commit if this change is OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user robguima commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-181600678
2) hmm string is one of the few things I like about C++ :) especially for,
like you said, code that is not in the main code path (e.g. debugging). It's
Github user robguima commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-181605333
@zwoop thought that was a pretty good argument myself. :) not a prob will
change it - also forgot you guys are multiplat...
---
If your project is set up for
Github user robguima commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-181994021
@zwoop @shukitchan please let me know if the std::string free version above
is OK - if so I will squash it thx
---
If your project is set up for it, you can
