Re: free lists 2.0

2018-12-10 Thread Walt Karas
It's a matter of intuition how much free lists improve TS performance, I'm not so sure it's worth it either. But I do feel it's clear that, if we are going to to use freelists, my implementation is strongly preferable. Based on the preferability of clear, minimal interfaces and lack of unnecessar

Re: free lists 2.0

2018-12-10 Thread James Peach
> On Dec 10, 2018, at 9:08 AM, Walt Karas wrote: > > It's a matter of intuition how much free lists improve TS performance, Is it? Can you benchmark with the -f and -F flags to verify the effect of free lists and the proxy allocator? J

Re: free lists 2.0

2018-12-10 Thread Walt Karas
Fei's being doing tests like this. But do we have a way of comparing two executables with realistic traffic and the same traffic twice? On Mon, Dec 10, 2018 at 12:10 PM James Peach wrote: > > > > > On Dec 10, 2018, at 9:08 AM, Walt Karas wrote: > > > > It's a matter of intuition how much free li

Re: free lists 2.0

2018-12-10 Thread SUSAN HINRICHS
Based on Fei's measurements, the ATS freelists provide no benefit over jemalloc. We are now in a position to do larger tests over our production installs. On Mon, Dec 10, 2018, 10:10 AM James Peach > > > On Dec 10, 2018, at 9:08 AM, Walt Karas wrote: > > > > It's a matter of intuition how much

Re: free lists 2.0

2018-12-10 Thread Leif Hedstrom
> On Dec 10, 2018, at 10:29 AM, SUSAN HINRICHS wrote: > > Based on Fei's measurements, the ATS freelists provide no benefit over > jemalloc. We are now in a position to do larger tests over our production > installs. Agreed, that was generally what I noticed too, except, I could not get ATS

Re: free lists 2.0

2018-12-10 Thread Walt Karas
As far as one can tell is a big limitation with code like: #if (defined(__i386__) || defined(__arm__) || defined(__mips__)) && > (SIZEOF_VOIDP == 4) > > #define FREELIST_POINTER(_x) (_x).s.pointer > > #define FREELIST_VERSION(_x) (_x).s.version > > #define SET_FREELIST_POINTER_VERSION(_x, _p, _v)