[GitHub] trafficserver pull request #790: TS-4472 Fixes http_current_active_client_co...

2016-07-08 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/790 TS-4472 Fixes http_current_active_client_connections_stat metric The issue here is that there are two m_active member variables, in both Http1ClientSession and Http1ClientTransaction. Howeve

[GitHub] trafficserver issue #790: TS-4472 Fixes http_current_active_client_connectio...

2016-07-08 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/790 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/415/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #790: TS-4472 Fixes http_current_active_client_connectio...

2016-07-08 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/790 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] trafficserver issue #790: TS-4472 Fixes http_current_active_client_connectio...

2016-07-08 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/790 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/309/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.

2016-07-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/770 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] trafficserver pull request #770: Integrate clang-tidy into the build.

2016-07-08 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/770 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #788: TS-4635: Fix RefCountCacheSerializer file d...

2016-07-08 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/788 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #790: TS-4472 Fixes http_current_active_client_connectio...

2016-07-08 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/790 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/763 @shinrich @masaori335 Should we land this patch though? I'm landing my other fix for the active client conns. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] trafficserver pull request #790: TS-4472 Fixes http_current_active_client_co...

2016-07-08 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/790 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-08 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/763 @zwoop Looks good. We should land this to add a option to get metrics per protocol. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/763 It does have merge conflicts, so maybe I should resolve that locally, and commit it with --author=susan ? @PSUdaemon wdyt? --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/763 I resolved the conflicts, I think: http://paste.fedoraproject.org/389174/80381301/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well