Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r57849578
--- Diff: proxy/http2/HPACK.h ---
@@ -90,31 +97,29 @@ class MIMEFieldWrapper
return _field;
}
+ bool
+ is_sensitive() con
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/542
TS-4313: Fix improper type conversion
https://issues.apache.org/jira/browse/TS-4313
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maskit/
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57860698
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
--- End diff --
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57880884
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @section li
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-203415277
There should be a test case for decreasing weights.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Yes, you can decrypt and proxy SSL traffic in forward mode. Typically
(always?) this is done in transparent mode.
http://trafficserver.readthedocs.org/en/latest/admin-guide/configuration/transparent-forward-proxying.en.html
You need to do the same termination of the SSL connection on the ATS bo
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-203478841
Nice catch! +1. I think we should mark this as a possibly back port to
6.1.2 as well.
Do you know if this bug is in 5.3.x as well? If so, it likely should g
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r57907840
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-203489537
``ptrdiff_t`` is the right type for pointer arithmetic.
That said, I don't really understand the problem here. If ``field`` is not
in the ``MIMEFieldBlockI
Github user brkishore commented on the pull request:
https://github.com/apache/trafficserver/pull/532#issuecomment-203623465
Cancelling this pull request and perform git rebase and submit again.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user brkishore closed the pull request at:
https://github.com/apache/trafficserver/pull/532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user sodabrew commented on the pull request:
https://github.com/apache/trafficserver/pull/532#issuecomment-203631767
You don't need to submit a new PR, you can just force-push a corrected set
of commits onto this branch and the PR will update automatically.
---
If your project
Hi,
I wanted to some customized functionality in ATS experimental plugin
stale_while_revalidate
so I change the following two conditions to true to trigger revalidation
for each cache hit.
1-
https://github.com/apache/trafficserver/blob/master/plugins/experimental/stale_while_revalidate/stale_wh
GitHub user brkishore opened a pull request:
https://github.com/apache/trafficserver/pull/543
TS-4266: Added GC collect in add module and delete module in ts_lua plugin.
Please refer Jira TS-4266 for more information.
You can merge this pull request into a Git repository by running:
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/543#issuecomment-203650097
thanks. will try to find some time to review and merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user shaygalon commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-203657654
For the 64K page size, a multiple of kernel page size would be fine and
more future proof. It would be better to have it as a variable and not a
constant, and a
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57996067
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @sectio
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-203732053
@jpeach
I added some codes for debug and got these output. The rare case is
happening.
(I built with --enable-debug and ASAN using clang on OSX.)
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57996306
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @sectio
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57996567
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @section li
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57996852
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @sectio
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-203736906
Oh interesting. It looks like the pointers are ~500GB apart, so that
certainly confirms the problem you found! I wonder if that is specific to the
ASAN virtual add
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-203739388
@maskit Please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r58004342
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,207 @@
+/** @file
+
+ Priority Queue Implementation using Min Heap.
+
+ @section li
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r58005044
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,207 @@
+/** @file
+
+ Priority Queue Implementation using Min Heap.
+
+ @sectio
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r58005122
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,207 @@
+/** @file
+
+ Priority Queue Implementation using Min Heap.
+
+ @section li
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-203783017
Looks good except the comparator part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
27 matches
Mail list logo
