Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53446831
--- Diff: proxy/http2/HTTP2.cc ---
@@ -484,246 +498,162 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
return PARSE_DONE;
}
-sta
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53448759
--- Diff: proxy/http2/HTTP2.cc ---
@@ -484,246 +498,162 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
return PARSE_DONE;
}
GitHub user meeramn opened a pull request:
https://github.com/apache/trafficserver/pull/487
TS 4065: change metrics to counters where appropriate
I have fixed some metrics which have counter semantics by changing them
from RECD_INT to RECD_COUNTER. Please review.
You can merge this
Github user meeramn closed the pull request at:
https://github.com/apache/trafficserver/pull/487
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user meeramn opened a pull request:
https://github.com/apache/trafficserver/pull/488
TS-4065: Change metrics to counters in RecordsConfig
I have fixed some metrics which have counter semantics by changing them
from RECD_INT to RECD_COUNTER. Please review.
You can merge this
Github user meeramn commented on the pull request:
https://github.com/apache/trafficserver/pull/487#issuecomment-186362347
Cleaned up some stale commits and restored it to good state.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186362474
Nit picking, but instead of BUILD_WEBP_TRANSFORM_PLUGIN, wouldn't it make
more sense to just say something like BUILD_HAS_IMAGEMAGICCPP or some such
(look for some
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186383393
@zwoop @shukitchan made changes as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/489
Ts 4212
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4212
Alternatively you can review and apply these c
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/489#discussion_r53529845
--- Diff: lib/ts/ink_memory.cc ---
@@ -209,6 +210,46 @@ ats_mlock(caddr_t addr, size_t len)
return res;
}
+void *
+ats_track
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/489#discussion_r53530177
--- Diff: lib/ts/ink_memory.cc ---
@@ -209,6 +210,46 @@ ats_mlock(caddr_t addr, size_t len)
return res;
}
+void *
+ats_track
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/481#issuecomment-186442215
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186449042
I am planning on having and option for {{ats_malloc}} to call the track
functions in the future. Still thinking about how to do it cleanly.
---
If your projec
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/489#discussion_r53533502
--- Diff: lib/ts/ink_memory.cc ---
@@ -209,6 +210,46 @@ ats_mlock(caddr_t addr, size_t len)
return res;
}
+void *
+ats_track
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186454283
I updated it with Phil's suggestion.
I can figure out later what to do about calling ats_malloc like function
within these tracking functions when I add
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186454905
:+1: This looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186464921
What about the equivalents to posix_memalign?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
18 matches
Mail list logo
