Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/324#issuecomment-162476486
Hey @jpeach I'm gonna land this within the next day (rebased into a single
commit), unless you have any other questions or concerns? But after my review
it appears
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/366
remove alloc_cache from NetAccept
remove alloc_cache from NetAccept & net_accept() to avoid mem leak on
~NetAccept().
add a condition check for vc==NULL follow allocate_vc().
You can merge
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/366#discussion_r46833574
--- Diff: iocore/net/UnixNetAccept.cc ---
@@ -112,9 +106,17 @@ net_accept(NetAccept *na, void *ep, bool blockable)
count = res;
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/366#issuecomment-162560602
A few questions -
1. Why is it the destruction of a `NetAccept` a concern - I thought that
only happened during process shutdown. Is there a case
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/367
TS-4057 Missing check for system call error
EPERM and EACCES are often consfused for each other.
EPERM means "operation not permitted", ie doing this would not be
in your best inte
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/367
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/359#issuecomment-162602947
Hi James,
I've squashed several commits and cleaned up the history, I'll be more
descriptive in the future. Also, I found that I had left in some cod
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/362
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jplevyak opened a pull request:
https://github.com/apache/trafficserver/pull/368
Add an experimental plugin to allow memcache clients to access cache â¦
â¦data.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jplevya
+1 on Centos 7 64bit.
On Mon, Dec 7, 2015 at 5:03 AM, Bryan Call wrote:
> The vote didn’t pass. There was one +1 binding and one -1 non-binding
> votes. I create another release candidate with a fix for TS-4055 in it.
>
> -Bryan
>
>
> > On Dec 2, 2015, at 3:54 PM, Bryan Call wrote:
> >
> > I'
Github user oknet commented on the pull request:
https://github.com/apache/trafficserver/pull/366#issuecomment-162803942
Answersï¼
1. to implement an one shot accept (like a ftp pasv mode)
2. accept_fn = net_accept, accept_fn is called from NetAccept
3. the alloc_cache poin
12 matches
Mail list logo
