Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/236#issuecomment-141484785
I think Phil merged this in to 5.3.2 so I'm closing the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/295#issuecomment-141487839
Merged under TS-3827. Let's restore the flags check under a separate JIRA.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
GitHub user jrushf1239k opened a pull request:
https://github.com/apache/trafficserver/pull/297
Modified the plugin to add back the Range request header at the TS_HTâ¦
â¦TP_SEND_RESPONSE_HDR_HOOK
so that custom logging of range requests works properly.
You can merge this
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141507617
@jrushf1239k : lgtm - pls run clang format on the patch, so, I can merge it.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141509647
Sudheer,
I ran clang format and pushed it.
Thanks
--
John J. Rushford
IPCDN Engineering
1400 Wewatta Street, Denver Colorado 8
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141509823
thanks, @jrushf1239k - merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141510195
thanks
Thanks
--
John J. Rushford
IPCDN Engineering
1400 Wewatta Street, Denver Colorado 80202
john_rushf...@cable.comcast.com
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141521724
You should use ```__func__``` in debug messages rather than typing the
function name all the tine :)
---
If your project is set up for it, you can reply to this e
Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141522795
Youâre right, I should have. Will do next time ;)
Thanks
--
John J. Rushford
IPCDN Engineering
1400 Wewatta Street, Denver Colorado
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141522930
As a separate ticket, if you just rename the original ```Range``` header to
```@Range```, you can remove the per-transaction data, saving yourself the
copying and
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141525465
@jpeach : I agree - but, one issue I could see in renaming Range to @Range,
is that, it's not transparent to custom logging configuration (the operators
need to
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/283#issuecomment-141525480
@PSUdaemon, @bgaff, @SolidWallOfCode: can you look at this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141525653
You would still re-add, but renaming means you don't need to do a bunch of
copies. I agree that restoring ```Range``` is the right thing.
---
If your project is s
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141528147
Ah, I see - you are basically suggesting to rename Range to @Range
temporarily and re-add @Range as Range. Of the top of my head, I don't know if
these operation
Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/297#issuecomment-141536125
Thatâs why I added it back as âRangeâ, so that it would be seamless
for those using custom logs. Otherwise theyâd have to read the source code
and/or
I¹ll look into this and some other changes jpeach suggested.
Thanks
--
John J. Rushford
IPCDN Engineering
1400 Wewatta Street, Denver Colorado 80202
john_rushf...@cable.comcast.com
On 9/18/15, 12:30 PM, "sudheerv" wrote:
>Github user sudheerv commented on the pull request:
>
>
*TL;DR: if you make a commit, and the tests fail-- there is a high
probability that your code change broke something. Please take the time to
figure out if the bug was you or not, and if it isn't let someone know--
the community can help. TSQA is back on, but tsqa-lint is off for now.*
I can under
>>
>
> Turns out there is a bug in the git plugin to jenkins that the error
> message is bad... (
> https://cloudbees.zendesk.com/hc/en-us/articles/205023034-Error-cloning-remote-repo-origin).
> After checking the repo out by logging into the box it seems that someone
> was on box modifying jenk
> On Sep 18, 2015, at 3:32 PM, Thomas Jackson wrote:
>
> *TL;DR: if you make a commit, and the tests fail-- there is a high
> probability that your code change broke something. Please take the time to
> figure out if the bug was you or not, and if it isn't let someone know--
> the community can
22 matches
Mail list logo
