Re: git commit: [TS-2688] atscppapi: new exmaple plugin Boom

2014-04-02 Thread Igor Galić
- Original Message - > Repository: trafficserver > Updated Branches: > refs/heads/master f347b0ddd -> 0521f07be > > > [TS-2688] atscppapi: new exmaple plugin Boom > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > Commit: http://git-wip-us.apache.org/repos/as

[API proposal] TSRedirectRetriesGet()

2014-04-02 Thread Leif Hedstrom
Hi, I’d like to extend these two (existing) APIs void TSRedirectUrlSet(TSHttpTxn txnp, const char* url, const int url_len); const char* TSRedirectUrlGet(TSHttpTxn txnp, int *url_len_ptr); with this addition: int TSRedirectRetriesGet() This allows for a plugin using

[API REVIEW] Modify string ownership for TSRedirectUrlSet()

2014-04-02 Thread Leif Hedstrom
Hi all, as part of the v5.0.0 API fixup’s, I’d like to change the string ownership “contract” for TSRedirectUrlSet(). Today, the incoming URL string is basically strdup()’ed, and in most use cases I can think of, it’d be more logical to stick to how we do other similar APIs, which is to assume

Re: [DISCUSS} Changes to TSHttpTxnErrorBodySet and TSHttpTxnSetHttpRetBody

2014-04-02 Thread James Peach
On Mar 25, 2014, at 11:48 PM, Nick Kew wrote: > On Tue, 2014-03-25 at 20:25 -0600, Phil Sorber wrote: > An API change like that affects existing plugins and could leave us needing some ugly #ifdef crap to support both before- and after- TS versions. Can I make a plea to avoid tha

Re: [API proposal] TSRedirectRetriesGet()

2014-04-02 Thread James Peach
On Apr 2, 2014, at 8:33 AM, Leif Hedstrom wrote: > Hi, > > I’d like to extend these two (existing) APIs > > void TSRedirectUrlSet(TSHttpTxn txnp, const char* url, const int > url_len); > const char* TSRedirectUrlGet(TSHttpTxn txnp, int *url_len_ptr); > > > with this addition: >

[GitHub] trafficserver pull request: TS-2589 Don't hold up the response unt...

2014-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: tsxs can be found in trafficserver-dev...

2014-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: Question about developing plugins using the C++ API

2014-04-02 Thread Acácio Centeno
We found out we were using the API in a wrong way, we were calling transaction.error() and this was causing the problem. Sorry for the inconvenience. On Tue, Apr 1, 2014 at 2:25 PM, Brian Geffon wrote: > Hi, > This sounds like a bug in the C++ API, would you mind creating a Jira > ticket and as

[GitHub] trafficserver pull request: TS-2584 Fix failed assert transforming...

2014-04-02 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/44#issuecomment-39381147 I'm not confident that this change is correct. The root cause of the assertion seems to be that `cache_info.transform_store` is not handled the same way as `cache_in

[GitHub] trafficserver pull request: TS-2584 Fix failed assert transforming...

2014-04-02 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/44#issuecomment-39381820 @SolidWallOfCode should review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request: TS-2578 Close the client connection wh...

2014-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [4/5] git commit: TS-2612: Indroduce TSHttpConnectWithProtoStack() API

2014-04-02 Thread James Peach
On Mar 27, 2014, at 8:35 PM, Yunkai Zhang wrote: > On Fri, Mar 28, 2014 at 8:00 AM, James Peach wrote: > >> On Mar 13, 2014, at 2:56 PM, James Peach wrote: >> >>> On Mar 11, 2014, at 8:12 PM, yun...@apache.org wrote: >>> TS-2612: Indroduce TSHttpConnectWithProtoStack() API 1)