I got stuck for a week on a regression test failure while trying to fix
TS-1077. I eventually tracked it down to NetVCOptions::frequent_accept
defaulting to true instead of false. Checking the source control logs it turns
out that I had it as false when I first checked in the main patch, but the
On 1/22/12 2:41 PM, Alan M. Carroll wrote:
I got stuck for a week on a regression test failure while trying to fix
TS-1077. I eventually tracked it down to NetVCOptions::frequent_accept
defaulting to true instead of false. Checking the source control logs it turns
out that I had it as false wh
Sunday, January 22, 2012, 4:28:27 PM, you wrote:
> Hmmm, this sounds awefully familiar, I think we had this exact problem once
> before as well, and I changed it back to "true" as it used to be.
Define "used to be". I specifically checked the 2.1.7 codebase and AFAICT it
used false in all "real
Sunday, January 22, 2012, 5:36:23 PM, you wrote:
> As for accept threads, my reading of the code is that if frequent_accept is
> false, then every normal IO thread also does accepts (via
> NetAccept::init_accept_per_thread).
No, that's wrong. It calls NetAccept::init_accept and starts a single
Hmmm, I'll have to go read the code again, after the 49ers game. That is not
how I remember it at all.
On Jan 22, 2012, at 4:36 PM, "Alan M. Carroll"
wrote:
> Sunday, January 22, 2012, 4:28:27 PM, you wrote:
>
>> Hmmm, this sounds awefully familiar, I think we had this exact problem once
>>
I could be wrong. It happened once before, so why not twice?
Sunday, January 22, 2012, 6:10:04 PM, you wrote:
> Hmmm, I'll have to go read the code again, after the 49ers game. That is not
> how I remember it at all.
Still watching the game at In The Zone, but, with your patch, does it still
support both accept threads (1 or more) and non-blocking accept on each
net-thread ?
On Jan 22, 2012, at 5:42 PM, "Alan M. Carroll"
wrote:
> I could be wrong. It happened once before, so why not twice?
>
> Sunday, Ja
On 1/22/12 7:13 PM, Leif Hedstrom wrote:
Still watching the game at In The Zone, but, with your patch, does it still
support both accept threads (1 or more) and non-blocking accept on each
net-thread ?
So, looking at some older code, v2.1.6 for example, where we passed around
frequent_accep
