Re: ssl conn and http

2017-11-07 Thread Dk Jack
All, I've created a PR to address issue #2380 (Missing ssl session close hook) and #2388 (Ability to add contextual data on (Net)VConnections). Would appreciate a review. The PR includes includes API documentation as well for #2388 and hence would appreciate a review for the documentation as well.

Re: ssl conn and http

2017-10-09 Thread Dk Jack
Never mind, I figured out the issue. Please ignore... thanks. On Mon, Oct 9, 2017 at 5:13 PM, Dk Jack wrote: > Alan, > I've been working on the issues we discussed. I have most of it working. > I've added two things: > > - Allow plugins to add user data to conn. > bool TSVConnSetUserData(TSVC

Re: ssl conn and http

2017-10-09 Thread Dk Jack
Alan, I've been working on the issues we discussed. I have most of it working. I've added two things: - Allow plugins to add user data to conn. bool TSVConnSetUserData(TSVConn connp, const char* name, void* data); void* TSVConnGetUserData(TSVConn connp, const char* name); Did not bother wit

Re: ssl conn and http

2017-09-27 Thread Alan Carroll
I don't think I'd do it for TLS_CLOSE, but VCONN_CLOSE would likely be worth it. There's an issue on that, linked from the issue I mentioned above. It's about the same thing - plugin wants to attach data during TLS handshake for later retrieval at the HTTP level that can be cleaned up if something

Re: ssl conn and http

2017-09-27 Thread Dk Jack
Yeah, I was thinking along similar lines... Do you think, it'd be a worth while effort to add a ssl-close event hook? On Wed, Sep 27, 2017 at 1:31 PM, Alan Carroll < solidwallofc...@oath.com.invalid> wrote: > I'd probably put a time stamp in and update it during the hook processing. > If you wai

Re: ssl conn and http

2017-09-27 Thread Alan Carroll
I'd probably put a time stamp in and update it during the hook processing. If you waited 5 minutes or so before clearing, that should be enough. If it's been 5 minutes since the last activity the connection should be dead, unless you're shipping big files. Or, alternatively, in READ_REQUEST_HDR_HO

Re: ssl conn and http

2017-09-27 Thread Dk Jack
I did try to see if there was a n openssl hook that gets invoked when the connection is closed. However, I couldn't find one. I guess it doesn't make sense to have one from openssl perspective since connection close is is always initiated by the application. What I need is a i.e a callback from SS

Re: ssl conn and http

2017-09-27 Thread Alan Carroll
Unfortunately I don't know of a reliable way to do clean up, which is one reason I would think of a plugin maintained table which at least has the possibility of cleanup. This does point out a problem with the mentioned issue - if that is done there must be some reliable way to clean it up. I'm no

Re: ssl conn and http

2017-09-26 Thread Dk Jack
Hi Alan, Thanks for the response. After looking at the code a bit more, I figured I can do something like this: TSHttpHookAdd(TS_EVENT_VCONN_PRE_ACCEPT, pre_accept_cb); pre_accept_callback(TSCont /*contp*/, TSEvent /*event*/, void *edata) { TSVConn ssl_vc = reinterpret_cast(edata); Connecti

Re: ssl conn and http

2017-09-26 Thread Alan Carroll
This is a known problem, see https://github.com/apache/trafficserver/issues/2388 . The point of that feature request is to be able to store data on the TSNetVConn (which you have in the SSL hook) and then retrieve it later in an HTTP hook (from which you can get to the same TSNetVConn). Currently I

ssl conn and http

2017-09-25 Thread Dk Jack
Hi, I am adding a hook to get access to the ssl handshake data. I am using something like: TSHttpHookAdd(TS_SSL_CERT_HOOK, cb_cert); In the ssl callback, I am extracting some info from the ssl connection and I'd like to save the info. I'd like to later retrieve this info when my Http hook call ba