Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-29 Thread James Peach
On May 29, 2014, at 12:19 AM, Wei Sun wrote: > > > On 5/29/14, 1:36 AM, "Bryan Call" wrote: > >> >> On May 26, 2014, at 6:00 PM, James Peach wrote: >> >>> Bryan, >>> >>> How are you expecting proxy.process.ssl.total_handshake_time to be >>> used? What units is it in? Unless I'm missing so

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-29 Thread Wei Sun
On 5/29/14, 1:36 AM, "Bryan Call" wrote: > >On May 26, 2014, at 6:00 PM, James Peach wrote: > >> Bryan, >> >> How are you expecting proxy.process.ssl.total_handshake_time to be >>used? What units is it in? Unless I'm missing something, the aggregate >>handshake time does not seem very interes

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-28 Thread Bryan Call
On May 26, 2014, at 6:00 PM, James Peach wrote: > Bryan, > > How are you expecting proxy.process.ssl.total_handshake_time to be used? What > units is it in? Unless I'm missing something, the aggregate handshake time > does not seem very interesting. We wanted to get a better picture of the S

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-27 Thread James Peach
On May 27, 2014, at 9:14 AM, Sudheer Vinukonda wrote: > > > On 5/27/14, 8:47 AM, "James Peach" wrote: > >> On May 27, 2014, at 7:33 AM, Sudheer Vinukonda >> wrote: >> >>> >>> >>> On 5/26/14, 6:00 PM, "James Peach" wrote: >>> Bryan, How are you expecting proxy.process.ssl

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-27 Thread Sudheer Vinukonda
On 5/27/14, 8:47 AM, "James Peach" wrote: >On May 27, 2014, at 7:33 AM, Sudheer Vinukonda >wrote: > >> >> >> On 5/26/14, 6:00 PM, "James Peach" wrote: >> >>> Bryan, >>> >>> How are you expecting proxy.process.ssl.total_handshake_time to be >>>used? >>> What units is it in? Unless I'm miss

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-27 Thread James Peach
On May 27, 2014, at 7:33 AM, Sudheer Vinukonda wrote: > > > On 5/26/14, 6:00 PM, "James Peach" wrote: > >> Bryan, >> >> How are you expecting proxy.process.ssl.total_handshake_time to be used? >> What units is it in? Unless I'm missing something, the aggregate >> handshake time does not seem

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-27 Thread James Peach
On May 27, 2014, at 6:47 AM, Alan M. Carroll wrote: > James, > > Monday, May 26, 2014, 8:00:59 PM, you wrote: > >> Where is proxy.process.spdy.total_streams decremented? > > I don't think it is - it is counting the total number of streams, which can > only increase. The "ACTIVE" variants cou

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-27 Thread Sudheer Vinukonda
On 5/26/14, 6:00 PM, "James Peach" wrote: >Bryan, > >How are you expecting proxy.process.ssl.total_handshake_time to be used? >What units is it in? Unless I'm missing something, the aggregate >handshake time does not seem very interesting. >From what I can see in the patch, proxy.process.ssl.

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-27 Thread Alan M. Carroll
James, Monday, May 26, 2014, 8:00:59 PM, you wrote: > Where is proxy.process.spdy.total_streams decremented? I don't think it is - it is counting the total number of streams, which can only increase. The "ACTIVE" variants count the number of objects currently extant. This is parallel to things

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-26 Thread James Peach
Bryan, How are you expecting proxy.process.ssl.total_handshake_time to be used? What units is it in? Unless I'm missing something, the aggregate handshake time does not seem very interesting. What does proxy.process.spdy.total_time mean, and how would I use it? Why does proxy.process.ssl.total