Re: git commit: TS-2555: add more hook support for ts_lua plugin

2014-05-21 Thread Shu Kit Chan
I agree that global functions for hooks is ugly. I can add similar thing as the lua plugin and allow registering hooks outside of global functions before 5.0.0 release. Quehan also has a patch with the idea of using the return value of the registered function of hooks to control the reenabling of

Re: git commit: TS-2555: add more hook support for ts_lua plugin

2014-05-21 Thread James Peach
On May 20, 2014, at 9:59 PM, kic...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master 90f44b522 -> 2ba2baaa6 > > > TS-2555: add more hook support for ts_lua plugin I still think that declaring global functions for hooks is ugly and not Lua-like. Automatical