> On Mar 2, 2015, at 1:18 PM, James Peach wrote:
>
>>
>> On Feb 28, 2015, at 8:57 PM, Leif Hedstrom wrote:
>>
>>
>>> On Feb 28, 2015, at 9:35 PM, Phil Sorber wrote:
>>>
>>> On Wed Feb 25 2015 at 9:15:38 AM James Peach wrote:
>>>
> On Feb 24, 2015, at 1:59 PM, Leif Hedstrom wro
> On Feb 28, 2015, at 8:57 PM, Leif Hedstrom wrote:
>
>
>> On Feb 28, 2015, at 9:35 PM, Phil Sorber wrote:
>>
>> On Wed Feb 25 2015 at 9:15:38 AM James Peach wrote:
>>
>>>
On Feb 24, 2015, at 1:59 PM, Leif Hedstrom wrote:
Hi,
clang-format has finally gotten to t
> On Feb 28, 2015, at 9:35 PM, Phil Sorber wrote:
>
> On Wed Feb 25 2015 at 9:15:38 AM James Peach wrote:
>
>>
>>> On Feb 24, 2015, at 1:59 PM, Leif Hedstrom wrote:
>>>
>>> Hi,
>>>
>>> clang-format has finally gotten to the point where we can get it to
>> format our code similar, but not q
> On Feb 24, 2015, at 2:59 PM, Leif Hedstrom wrote:
>
> Hi,
>
> clang-format has finally gotten to the point where we can get it to format
> our code similar, but not quite identical, to what we have today. Doing all
> formatting programmatically has several benefits:
>
> It’s no longer up t
On Wed Feb 25 2015 at 9:15:38 AM James Peach wrote:
>
> > On Feb 24, 2015, at 1:59 PM, Leif Hedstrom wrote:
> >
> > Hi,
> >
> > clang-format has finally gotten to the point where we can get it to
> format our code similar, but not quite identical, to what we have today.
> Doing all formatting pr
> On Feb 24, 2015, at 1:59 PM, Leif Hedstrom wrote:
>
> Hi,
>
> clang-format has finally gotten to the point where we can get it to format
> our code similar, but not quite identical, to what we have today. Doing all
> formatting programmatically has several benefits:
>
> It’s no longer up t
On Wed Feb 25 2015 at 4:21:09 AM Nick Kew wrote:
> On Wed, 2015-02-25 at 03:04 +, Phil Sorber wrote:
>
> > This link might help:
> > https://github.com/zwoop/trafficserver/compare/clang-format
>
> Aaargh! No!!! Unless perhaps you have a supercomputer.
>
> That URL just made Iceweasel so unr
On Wed, 2015-02-25 at 03:04 +, Phil Sorber wrote:
> This link might help:
> https://github.com/zwoop/trafficserver/compare/clang-format
Aaargh! No!!! Unless perhaps you have a supercomputer.
That URL just made Iceweasel so unresponsive I can't even hit
the "stop loading" button. Plain tex
Also, I found that there’s a git-clang-format script that comes with all this.
E.g.
heimdall (21:25) 368/2 $ git clang-format --commit HEAD^
changed files:
cmd/traffic_cop/traffic_cop.cc
This would run clang-format against all the files from the last commit, and
“fix them". It has a bunch
> On Feb 24, 2015, at 8:23 PM, Leif Hedstrom wrote:
>
>>
>> On Feb 24, 2015, at 8:04 PM, Phil Sorber wrote:
>>
>> On Tue Feb 24 2015 at 7:36:51 PM Leif Hedstrom wrote:
>>
>>>
On Feb 24, 2015, at 5:30 PM, Bryan Call wrote:
It would be good to see how well it does on formatt
> On Feb 24, 2015, at 8:04 PM, Phil Sorber wrote:
>
> On Tue Feb 24 2015 at 7:36:51 PM Leif Hedstrom wrote:
>
>>
>>> On Feb 24, 2015, at 5:30 PM, Bryan Call wrote:
>>>
>>> It would be good to see how well it does on formatting before agreeing
>>
>>
> This link might help:
> https://github
On Tue Feb 24 2015 at 7:36:51 PM Leif Hedstrom wrote:
>
> > On Feb 24, 2015, at 5:30 PM, Bryan Call wrote:
> >
> > It would be good to see how well it does on formatting before agreeing
> to do it to the entire tree.
>
>
> Btw, I meant to imply that everyone can play with clang-format themselves
> On Feb 24, 2015, at 5:30 PM, Bryan Call wrote:
>
> It would be good to see how well it does on formatting before agreeing to do
> it to the entire tree.
Btw, I meant to imply that everyone can play with clang-format themselves,
that’s why I checked in the .clang-format in the git repo :).
> On Feb 24, 2015, at 3:19 PM, Alan Carroll
> wrote:
>
> Mayne you could do a few files first and let us see the results.
See https://github.com/zwoop/trafficserver/tree/clang-format
For example,
https://github.com/zwoop/trafficserver/blob/clang-format/proxy/http/HttpTransact.cc
— Leif
It would be good to see how well it does on formatting before agreeing to do it
to the entire tree.
-Bryan
> On Feb 24, 2015, at 2:40 PM, Leif Hedstrom wrote:
>
>
>> On Feb 24, 2015, at 3:19 PM, Alan Carroll
>> wrote:
>>
>> Mayne you could do a few files first and let us see the results
> On Feb 24, 2015, at 3:19 PM, Alan Carroll
> wrote:
>
> Mayne you could do a few files first and let us see the results.
>
>
>
I can do a full run, and push it to my github mirror. I’ll work on that tonight.
— Leif
Mayne you could do a few files first and let us see the results.
On Tue Feb 24 2015 at 2:59:52 PM Leif Hedstrom wrote:
> Hi,
>
> clang-format has finally gotten to the point where we can get it to format
> our code similar, but not quite identical, to what we have today. Doing all
> formatting programmatically has several benefits:
>
> It’s no longer up to sub
Hi,
clang-format has finally gotten to the point where we can get it to format our
code similar, but not quite identical, to what we have today. Doing all
formatting programmatically has several benefits:
It’s no longer up to subjective or personal preferences, we’ll learn to live
and love the
19 matches
Mail list logo
