Re: Unit Testing

2017-07-10 Thread Jason Kenny
I am making a PR for this Jason On Sunday, July 9, 2017, 4:03:44 PM CDT, Leif Hedstrom wrote: > On Jul 9, 2017, at 8:00 AM, Alan Carroll > wrote: > > I have PR 2254 which is a conversion of IpMapTest from our internal > regression test / TestBox to Catch. Overall I think Catch is clearly be

Re: Unit Testing

2017-07-09 Thread Leif Hedstrom
> On Jul 9, 2017, at 8:00 AM, Alan Carroll > wrote: > > I have PR 2254 which is a conversion of IpMapTest from our internal > regression test / TestBox to Catch. Overall I think Catch is clearly better > than gtest. > So, we could just include this in our source tree, and that’s it?

Re: Unit Testing

2017-07-09 Thread Alan Carroll
I have PR 2254 which is a conversion of IpMapTest from our internal regression test / TestBox to Catch. Overall I think Catch is clearly better than gtest.

Unit Testing

2017-07-07 Thread Jason Kenny
Hi all, There was a talk about using gtest or something else for unit testing. I had suggested Catch instead, however, I think everyone without looking or trying anything out said gtest. So to help get a real test written I have various PR coming with unit tests. I had my interns write tests in

Re: Unit testing for plugin

2016-04-25 Thread Karthik Sivaraman
Thanks Gancho. This is very helpful Karthik From: Gancho Tenev Sent: Friday, April 22, 2016 4:05 PM To: dev@trafficserver.apache.org Subject: Re: Unit testing for plugin Karthik, If interested in regression / integration testing (trafficserver+plugin

Re: Unit testing for plugin

2016-04-22 Thread Gancho Tenev
_ > From: Brian Geffon > Sent: Friday, April 22, 2016 8:46 AM > To: dev@trafficserver.apache.org > Subject: Re: Unit testing for plugin > > Take a look at the open pull requests, there are c++ API mocks that are > hopefully going to land soon too. > >

Re: Unit testing for plugin

2016-04-22 Thread Karthik Sivaraman
Thanks all. Will follow up on these links Karthik From: Brian Geffon Sent: Friday, April 22, 2016 8:46 AM To: dev@trafficserver.apache.org Subject: Re: Unit testing for plugin Take a look at the open pull requests, there are c++ API mocks that are

Re: Unit testing for plugin

2016-04-22 Thread James Peach
> On Apr 22, 2016, at 7:01 AM, Karthik Sivaraman > wrote: > > Hi > > > We are planning to maintain a plug-in that does third party feed based URL > filtering. Are there any recommendations for unit test/regression test > frameworks? What does trafficserver use for its unit/regression tests?

Re: Unit testing for plugin

2016-04-22 Thread Brian Geffon
Take a look at the open pull requests, there are c++ API mocks that are hopefully going to land soon too. Brian On Friday, April 22, 2016, James Peach wrote: > > > On Apr 22, 2016, at 7:01 AM, Karthik Sivaraman < > karthiksivara...@outlook.com > wrote: > > > > Hi > > > > > > We are planning to

Re: Unit testing for plugin

2016-04-22 Thread Jason Kenny
Have to remember the joy of e-mail at yahoo Let me try to get a good link to catch https://github.com/philsquared/Catch Jason From: Jason Kenny To: "dev@trafficserver.apache.org" Sent: Friday, April 22, 2016 9:56 AM Subject: Re: Unit testing for plugin I am planning on

Re: Unit testing for plugin

2016-04-22 Thread Jason Kenny
I am planning on proposing the use of philsquared/Catch | | | | || | | | || philsquared/Catch Catch - A modern, C++-native, header-only, framework for unit-tests, TDD and BDD | | | | for unit testing as part of my work on fixing up testing ATS within

Unit testing for plugin

2016-04-22 Thread Karthik Sivaraman
Hi We are planning to maintain a plug-in that does third party feed based URL filtering. Are there any recommendations for unit test/regression test frameworks? What does trafficserver use for its unit/regression tests? Thanks Karthik

Re: TDD/Unit testing ATS plugins

2014-03-10 Thread James Peach
On Mar 8, 2014, at 5:28 PM, Alan Cabrera wrote: > So, I took a crack at this and it seems that InkAPI.cc has a mix of API and > utility code; utility code being calls such as TSUrlSchemeGet(). > > To me it seems to only make sense to mock API calls such as > TSPluginRegister() and _TSmall

Re: TDD/Unit testing ATS plugins

2014-03-08 Thread Alan Cabrera
So, I took a crack at this and it seems that InkAPI.cc has a mix of API and utility code; utility code being calls such as TSUrlSchemeGet(). To me it seems to only make sense to mock API calls such as TSPluginRegister() and _TSmalloc(). But how will mocked tests execute code that uses both

Re: TDD/Unit testing ATS plugins

2014-02-26 Thread Alan Cabrera
Thanks! I’m going to start tinkering around in https://github.com/maguro/trafficserver Feel free to watch or, even better, help! Regards, Alan On Feb 25, 2014, at 3:07 PM, James Peach wrote: > On Feb 24, 2014, at 7:51 PM, Alan Cabrera wrote: > >> I wanted to start goofing around with thi

Re: TDD/Unit testing ATS plugins

2014-02-25 Thread James Peach
On Feb 24, 2014, at 7:51 PM, Alan Cabrera wrote: > I wanted to start goofing around with this in a public place so people can > comment/participate. Would it make sense to do this on github and if it ever > gels into something useful I could submit a patch? Take a look at ci/tsqa. I started a

Re: TDD/Unit testing ATS plugins

2014-02-25 Thread Leif Hedstrom
> On Feb 24, 2014, at 8:51 PM, Alan Cabrera wrote: > > I wanted to start goofing around with this in a public place so people can > comment/participate. Would it make sense to do this on github and if it ever > gels into something useful I could submit a patch? Yep, just fork the official A

Re: TDD/Unit testing ATS plugins

2014-02-24 Thread Alan Cabrera
I wanted to start goofing around with this in a public place so people can comment/participate. Would it make sense to do this on github and if it ever gels into something useful I could submit a patch? Regards, Alan On Jan 10, 2014, at 11:41 AM, Alan Cabrera wrote: > +1 a good mocked libra

Re: TDD/Unit testing ATS plugins

2014-01-10 Thread Alan Cabrera
+1 a good mocked library would be awesome. Do more experienced ATS developers know of any blockers to us writing a mock library for testing? Regards, Alan On Jan 10, 2014, at 11:08 AM, Shu Kit Chan wrote: > That's just unit tests for utilities and helper classes for the plugin. > I also wa

Re: TDD/Unit testing ATS plugins

2014-01-10 Thread Shu Kit Chan
That's just unit tests for utilities and helper classes for the plugin. I also want a stub library, too, for writing unit tests for plugin. On Fri, Jan 10, 2014 at 10:59 AM, James Peach wrote: > On Jan 3, 2014, at 8:48 AM, Alan D. Cabrera wrote: > > > > > On Jan 2, 2014, at 9:04 AM, James Peac

Re: TDD/Unit testing ATS plugins

2014-01-10 Thread James Peach
On Jan 3, 2014, at 8:48 AM, Alan D. Cabrera wrote: > > On Jan 2, 2014, at 9:04 AM, James Peach wrote: > >> On Dec 31, 2013, at 2:44 PM, Alan D. Cabrera wrote: >> >>> >>> On Dec 31, 2013, at 1:53 PM, James Peach wrote: >>> On Dec 31, 2013, at 8:44 AM, Alan D. Cabrera wrote: >>>

Re: TDD/Unit testing ATS plugins

2014-01-03 Thread Alan D. Cabrera
On Jan 2, 2014, at 9:04 AM, James Peach wrote: > On Dec 31, 2013, at 2:44 PM, Alan D. Cabrera wrote: > >> >> On Dec 31, 2013, at 1:53 PM, James Peach wrote: >> >>> On Dec 31, 2013, at 8:44 AM, Alan D. Cabrera wrote: >>> I'm looking for an example of an ATS plugin that has extensive u

Re: TDD/Unit testing ATS plugins

2014-01-02 Thread Bryan Call
It was part of the unit tests for the cookie remap plugin. I ported the plugin to ATS along with the unit tests and we are using it in production. I think it would be best to open source both the stub and the plugin and then move the stub parts into a common directory. The plugin does use some

Re: TDD/Unit testing ATS plugins

2014-01-02 Thread James Peach
On Dec 31, 2013, at 2:44 PM, Alan D. Cabrera wrote: > > On Dec 31, 2013, at 1:53 PM, James Peach wrote: > >> On Dec 31, 2013, at 8:44 AM, Alan D. Cabrera wrote: >> >>> I'm looking for an example of an ATS plugin that has extensive unit tests. >> >> There are none. >> >>> I'm having problem

Re: TDD/Unit testing ATS plugins

2013-12-31 Thread Alan D. Cabrera
On Dec 31, 2013, at 1:53 PM, James Peach wrote: > On Dec 31, 2013, at 8:44 AM, Alan D. Cabrera wrote: > >> I'm looking for an example of an ATS plugin that has extensive unit tests. > > There are none. > >> I'm having problems linking my Boost unit tests against the plugin library >> for ob

Re: TDD/Unit testing ATS plugins

2013-12-31 Thread James Peach
On Dec 31, 2013, at 8:44 AM, Alan D. Cabrera wrote: > I'm looking for an example of an ATS plugin that has extensive unit tests. There are none. > I'm having problems linking my Boost unit tests against the plugin library > for obvious reasons, it's a module not a shared library. > > I tried

Re: TDD/Unit testing ATS plugins

2013-12-31 Thread Alan D. Cabrera
On Dec 31, 2013, at 10:11 AM, Leif Hedstrom wrote: > > On Dec 31, 2013, at 9:44 AM, Alan D. Cabrera wrote: > >> I'm looking for an example of an ATS plugin that has extensive unit tests. >> >> I'm having problems linking my Boost unit tests against the plugin library >> for obvious reasons,

TDD/Unit testing ATS plugins

2013-12-31 Thread Alan D. Cabrera
I'm looking for an example of an ATS plugin that has extensive unit tests. I'm having problems linking my Boost unit tests against the plugin library, for obvious reasons, it's a module not a shared library. I tried setting up an internal static library that the tests would link against but can

Re: TDD/Unit testing ATS plugins

2013-12-31 Thread Leif Hedstrom
On Dec 31, 2013, at 9:44 AM, Alan D. Cabrera wrote: > I'm looking for an example of an ATS plugin that has extensive unit tests. > > I'm having problems linking my Boost unit tests against the plugin library > for obvious reasons, it's a module not a shared library. > > I tried setting up an

TDD/Unit testing ATS plugins

2013-12-31 Thread Alan D. Cabrera
I'm looking for an example of an ATS plugin that has extensive unit tests. I'm having problems linking my Boost unit tests against the plugin library for obvious reasons, it's a module not a shared library. I tried setting up an internal static library that the tests would link against but can'

Re: Unit testing of ATS

2012-07-18 Thread James Peach
On Jul 18, 2012, at 12:23 PM, Leif Hedstrom wrote: > On 7/18/12 11:43 AM, Adam Phelps wrote: >> For these regression tests is it a release requirement that they fully pass? ie should they pass cleanly when run against the current 3.2.0 release? >>> >>> Yep. They only pas

Re: Unit testing of ATS

2012-07-18 Thread Leif Hedstrom
On 7/18/12 11:43 AM, Adam Phelps wrote: For these regression tests is it a release requirement that they fully pass? ie should they pass cleanly when run against the current 3.2.0 release? Yep. They only pass with the default configs though, so have to make a fresh install and run the re

Re: Unit testing of ATS

2012-07-18 Thread Adam Phelps
On 7/18/12 11:03 AM, Leif Hedstrom wrote: On 7/18/12 10:45 AM, Adam Phelps wrote: On 7/18/12 10:32 AM, Leif Hedstrom wrote: On 7/18/12 8:56 AM, Adam Phelps wrote: I'm looking to do make some changes to ATS in addition to doing some work on a plugin, and generally have a preference to to have u

Re: Unit testing of ATS

2012-07-18 Thread Leif Hedstrom
On 7/18/12 10:45 AM, Adam Phelps wrote: On 7/18/12 10:32 AM, Leif Hedstrom wrote: On 7/18/12 8:56 AM, Adam Phelps wrote: I'm looking to do make some changes to ATS in addition to doing some work on a plugin, and generally have a preference to to have unit tests for most of the stuff I write.

Re: Unit testing of ATS

2012-07-18 Thread Adam Phelps
On 7/18/12 10:32 AM, Leif Hedstrom wrote: On 7/18/12 8:56 AM, Adam Phelps wrote: I'm looking to do make some changes to ATS in addition to doing some work on a plugin, and generally have a preference to to have unit tests for most of the stuff I write. I figured I'd first look into what testin

Re: Unit testing of ATS

2012-07-18 Thread Leif Hedstrom
On 7/18/12 8:56 AM, Adam Phelps wrote: I'm looking to do make some changes to ATS in addition to doing some work on a plugin, and generally have a preference to to have unit tests for most of the stuff I write. I figured I'd first look into what testing was already in the ATS code base, and se

Unit testing of ATS

2012-07-18 Thread Adam Phelps
I'm looking to do make some changes to ATS in addition to doing some work on a plugin, and generally have a preference to to have unit tests for most of the stuff I write. I figured I'd first look into what testing was already in the ATS code base, and see a decent number of tests. However it