Re: Tunnel API, hook proposal

2023-09-25 Thread Masakazu Kitajo
I approved the PR, but just to conclude the discussion here, I was convinced that having "Txn" in the function name makes sense. The return value for transactions that receive CONNECT method could be differentiated (e.g. TS_TXN_TYPE_CONNECT_TUNNEL), but I don't have a strong opinion here. It's easy

Re: Tunnel API, hook proposal

2023-09-22 Thread SUSAN HINRICHS
And Connect always confuses me. Let me test that scenario. On Fri, Sep 22, 2023, 4:24 PM Masakazu Kitajo wrote: > Hmm, I probably don't completely understand tunneling on ATS, especially > the tr-* stuff, but ok. I don't think we should copy information. > > Another question. Is this also relate

Re: Tunnel API, hook proposal

2023-09-22 Thread Masakazu Kitajo
Hmm, I probably don't completely understand tunneling on ATS, especially the tr-* stuff, but ok. I don't think we should copy information. Another question. Is this also related to CONNECT method? If so, the transaction that received CONNECT method returns TRUE when TSHttpTxnTypeGet is called? Doe

Re: Tunnel API, hook proposal

2023-09-21 Thread SUSAN HINRICHS
I looked at this a bit more, and it really is functionally an attribute of the transaction. The transaction is either a HTTP request or a tunnel. And if it is a tunnel it can be a tunnel because of a config or API call. Or it can be a tunnel due to a parse error (if tr-pass is enabled). We could

Re: Tunnel API, hook proposal

2023-09-19 Thread SUSAN HINRICHS
Sorry, I missed this in my clogged inbox. It is a characteristic of the vconn. Either the vconn is tunneled (based on parse failure or configuration) or all the transactions will be HTTP. However from an implementation perspective this is information we pull from the HttpSM. Let me think a bit

Re: Tunnel API, hook proposal

2023-09-13 Thread Masakazu Kitajo
Is it possible that the types of transactions on a connection are different? I suppose it's a type of connection or session. - Masakazu On Mon, Sep 11, 2023 at 5:22 PM SUSAN HINRICHS wrote: > I propose adding a new hook TS_HTTP_TUNNEL_START_HOOK. It triggers when a > blind tunnel starts. A plug

Tunnel API, hook proposal

2023-09-11 Thread SUSAN HINRICHS
I propose adding a new hook TS_HTTP_TUNNEL_START_HOOK. It triggers when a blind tunnel starts. A plugin using this hook has the opportunity to use some other information (e.g., policy, time of day, cat entrails) to determine whether the blind tunnel should be allowed. I also propose a new API TS