Re: git commit: TS-2863: Enable FQDN selection for shared sessions.

2014-07-28 Thread Alan M. Carroll
I would like to note that another purpose of the FQDN change is to provide better encapsulation for server session management with an eye to future work in making that more accessible to plugins and other core code.

Re: git commit: TS-2863: Enable FQDN selection for shared sessions.

2014-07-28 Thread Alan M. Carroll
James, Friday, July 25, 2014, 3:59:18 PM, you wrote: > Still reviewing, but I wish this had been a number of smaller patches. For > example, const'ing the MD5 stuff and adding ~PluginIdentity() could have been > independent patches ... Yes, the ~PluginIdentity() is a leak from some other work

Re: git commit: TS-2863: Enable FQDN selection for shared sessions.

2014-07-25 Thread James Peach
Still reviewing, but I wish this had been a number of smaller patches. For example, const'ing the MD5 stuff and adding ~PluginIdentity() could have been independent patches ... On Jul 24, 2014, at 7:20 PM, a...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/mast