Re: git commit: TS-2555 add global plugin support for ts_lua plugin

2014-04-17 Thread James Peach
On Apr 17, 2014, at 9:01 AM, Leif Hedstrom wrote: > > On Apr 16, 2014, at 8:19 PM, 李刚(阙寒) wrote: > >> Maybe we can use the same lua_States in both remap and global plugins. >> >> > > > Not exactly related, but one thing that really bothers me with the new plugin > is how in a remap rule (

Re: git commit: TS-2555 add global plugin support for ts_lua plugin

2014-04-17 Thread Leif Hedstrom
On Apr 16, 2014, at 8:19 PM, () wrote: > Maybe we can use the same lua_States in both remap and global plugins. > > Not exactly related, but one thing that really bothers me with the new plugin is how in a remap rule (do_remap()) it always saves away the context, and creates a new

Re: git commit: TS-2555 add global plugin support for ts_lua plugin

2014-04-17 Thread James Peach
On Apr 16, 2014, at 7:19 PM, 李刚(阙寒) wrote: > Maybe we can use the same lua_States in both remap and global plugins. They have different lifetimes, and script authors probably expect some degree of isolation between plugin instances. Take a look at how the lua plugin solves this problem; you mi

Re: git commit: TS-2555 add global plugin support for ts_lua plugin

2014-04-17 Thread Shu Kit Chan
I will take some time to refine this over the weekend. Thanks. On Wed, Apr 16, 2014 at 7:19 PM, 李刚(阙寒) wrote: > Maybe we can use the same lua_States in both remap and global plugins. > > 在 2014-4-17,上午12:03,James Peach 写道: > > > On Apr 15, 2014, at 10:34 PM, kic...@apache.org wrote: > > > >> R

Re: git commit: TS-2555 add global plugin support for ts_lua plugin

2014-04-16 Thread 李刚(阙寒)
Maybe we can use the same lua_States in both remap and global plugins. 在 2014-4-17,上午12:03,James Peach 写道: > On Apr 15, 2014, at 10:34 PM, kic...@apache.org wrote: > >> Repository: trafficserver >> Updated Branches: >> refs/heads/master 9f509d401 -> 904e1f7c2 >> >> >> TS-2555 add global plugi

Re: git commit: TS-2555 add global plugin support for ts_lua plugin

2014-04-16 Thread James Peach
On Apr 15, 2014, at 10:34 PM, kic...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master 9f509d401 -> 904e1f7c2 > > > TS-2555 add global plugin support for ts_lua plugin > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > Commit: http:/